Ensure the /user/files directory is always present in the FS

[jvillafanez]

Description

Ensure the user's folder always exists. In addition, update the login timestamp after the user is prepared to login, in particular, after the skeleton files have been copied.

Related Issue

https://github.com/owncloud/enterprise/issues/5187

Motivation and Context

There might be temporary errors preventing the user's folder from being created properly. If this happens, the admin would need to create the directory by himself. This PR ensure that the user's folder is eventually created, assuming it's a temporary error.

How Has This Been Tested?

Manually tested.

1. Login with a user
2. Remove the "/user/files" directory from the command line
3. Login again with the same user

The "/user/files" directory is recreated.
Note that step 2 is mostly for testing. The real expectation is that something goes wrong during the log in in step 1 and the "/user/files" directory isn't created in the first place.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[ownclouders]

💥 Acceptance tests pipeline apiFederationToShares1-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35841/111

[phil-davis]

boom Acceptance tests pipeline apiFederationToShares2-git-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/35802/114

Initialized empty Git repository in /drone/src/.git/

+ git fetch origin +refs/heads/master:
error: RPC failed; curl 56 OpenSSL SSL_read: Connection reset by peer, errno 104
fatal: the remote end hung up unexpectedly
fatal: early EOF
fatal: index-pack failed

https://www.githubstatus.com/incidents/gcqz5grcs4z6 - there was an incident with GitHub that says it was resolved 40 minutes ago. Maybe it is not really resolved. Someone should restart CI "in a while".

[phil-davis]

https://drone.owncloud.com/owncloud/core/35842/21/8
PHP unit tests
There were 8 failures:

This is issue #40098 and will block any merging of core PRs. I really don't know how to fix it.

Edit: fixed in #40101

[mmattel]

@jvillafanez you have status 3-to review, this will hang forever if there is no reviewer set...

[phil-davis]

"This branch is 2 commits ahead, 92 commits behind master."

It will be good to rebase also.

[phil-davis]

Changelog also needed

[jvillafanez]

Rebased, phpdocs and changelog added. I've also added the optional parameter in the interface.

[jvillafanez]

It might need some additional testing due to f711efa#diff-6d9986f514cef64fbfae8dffa32eb7a38d35c9eda651e4ddf4d6c7bc2b4af884R95-R97
The change should be backwards-compatible so it shouldn't break anything.

Change reverted. The public interface won't change, and the private implementation will use the additional parameter. We'll keep it as an internal change.

[phil-davis]

LGTM

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

87.5% Coverage
0.0% Duplication

[JammingBen]

Code LGTM 👍