Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing js file #40143

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Add missing js file #40143

merged 2 commits into from
Jun 17, 2022

Conversation

jvillafanez
Copy link
Member

Description

The missing js file was causing a crash in the js thread, preventing showing the action menu in public links. The crash is fixed and the menu shows up now.

Related Issue

https://github.com/owncloud/enterprise/issues/5166

Motivation and Context

The crash happen when the file is clicked, but before the expected popup menu is shown (

var appSelectMenu = new OCA.Files.FileActionsApplicationSelectMenu();
). I guess the "click" wasn't prevented due to the crash, which instead of showing the popup menu, the browser acted as if the file was clicked normally, redirecting the user to the first app that could handle the file type (or maybe downloading the file)

How Has This Been Tested?

Install the pdf viewer and the collabora apps, and then follow the steps in the issue. A popup menu appears now.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Jun 15, 2022
@owncloud owncloud deleted a comment from update-docs bot Jun 16, 2022
@phil-davis
Copy link
Contributor

@jvillafanez
https://drone.owncloud.com/owncloud/core/36049/4/2

changelog pipeline complains: file changelog/unreleased/40143: title ends with punctuation, e.g. a character out of ".!?"

@sonarcloud
Copy link

sonarcloud bot commented Jun 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mmattel mmattel merged commit 3d802c3 into master Jun 17, 2022
@delete-merged-branch delete-merged-branch bot deleted the action_menu_public_link branch June 17, 2022 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants