Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration option to bypass proxy settings for some domains #40148

Merged
merged 2 commits into from
Jun 23, 2022
Merged

Add configuration option to bypass proxy settings for some domains #40148

merged 2 commits into from
Jun 23, 2022

Conversation

jvillafanez
Copy link
Member

Description

The proxy config option allows the admin to set a proxy that will be used for the ownCloud requests. The new proxy_ignore option will allow the bypass of that proxy for specific domains

Related Issue

https://github.com/owncloud/enterprise/issues/4979

Motivation and Context

Some domains might not need to go through the proxy.

How Has This Been Tested?

Manually tested

  1. Configure mitmproxy and expose a port for it
  2. Set the proxy setting in ownCloud to use the proxy configured in step 1
  3. Go to the market app and try to load the contents

With the proxy active, the proxy should log the request. It might also reject the request due to SSL certificates, but an error should appear in the proxy.
Setting the new 'proxy_ignore' => ['.owncloud.com'] (for example), the market app is expected to load successfully without going through the proxy, so there shouldn't be any activity there.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Jun 17, 2022
@mmattel
Copy link
Contributor

mmattel commented Jun 17, 2022

Hooking myself in, needs a config-to-docs run when merged.

@mmattel
Copy link
Contributor

mmattel commented Jun 20, 2022

@jvillafanez you have status 3-to review, this will hang forever if there is no reviewer set...

phil-davis
phil-davis reviewed Jun 20, 2022
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need a changelog.

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@phil-davis phil-davis self-requested a review June 20, 2022 11:00
@owncloud owncloud deleted a comment from update-docs bot Jun 23, 2022
@phil-davis phil-davis merged commit 2c07b1c into master Jun 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the add_proxy_ignore branch June 23, 2022 12:21
@mmattel mmattel mentioned this pull request Jun 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@IljaN IljaN Awaiting requested review from IljaN

@JammingBen JammingBen Awaiting requested review from JammingBen

Assignees

@jvillafanez jvillafanez

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvillafanez @mmattel @phil-davis @AlexAndBear