Complete apache auth (SAML/SSO) flow with redirect page#40161
Complete apache auth (SAML/SSO) flow with redirect page#40161phil-davis merged 2 commits intomasterfrom
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
999e055 to
d27da44
Compare
d27da44 to
90f4a67
Compare
90f4a67 to
0b6a04b
Compare
|
I did not add acceptance tests as part of this PR, as these need to be in the apps handling the backend, in here we can only cover with unit tests |
|
@d7oc maybe of interest for you |
|
@janackermann @DeepDiver1975 could you have a look here? target for this is oc10.11 |
|
I just made a small doc fix, unhide to see details. |
|
💥 Acceptance tests pipeline apiWebdavPreviews-mariadb10.2-php7.4 failed. The build has been cancelled. |
|
As discussed offline - as long as this works 👍 |
|
@phil-davis I just added a comment text fix which resulted in |
5f48833 to
d23f5db
Compare
This PR was quite a lot of commits behind master. I rebased just now - let's see if CI is happier. |
|
https://drone.owncloud.com/owncloud/core/36296/97/14 That is failing in master today - issue owncloud/QA#750 - it is being looked at... |
d23f5db to
c70ae52
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
Kudos, SonarCloud Quality Gate passed! |
|
@phil-davis btw, as mentioned in https://github.com/owncloud/enterprise/issues/5225#issuecomment-1167075255 and https://github.com/owncloud/enterprise/issues/5225#issuecomment-1166973577, as there is no acceptance test in user_shibolleth , we would need to make sure all works with SAML/SSO enabled in QA env. |








Description
Without this change, server-side redirect to default page for Apache Auth (e.g. Shibboleth) resulted in session data missing on client side. Flow was incomplete and was missing final redirect page on client side to correctly handle redirect_url and persist the session data on the client.
Related Issue
How Has This Been Tested?
Types of changes
Checklist: