Init encryption module before calculating unencrypted block-size

[IljaN]

Description

Fixes a bug where the un-encrypted blocksize was calculated before initializing the encryption-module. This yields the wrong size after a file-scan. The issue is only triggered if encryption.use_legacy_encoding is set to true.

Related Issue

Related test PR: owncloud/encryption#360 (comment)

Motivation and Context

When restoring encrypted files from backup and doing a occ file:scan --repair and encryption:fix-encrypted-version the file was still not readable correctly because the size in oc_filecache is wrong.

The wrong calculation was introduced via #38249 where the size calculation depends on the encoding mode (binary vs base64). The code assumes that the begin method is called before the size is calculated which is not the case for the call-site which this PR fixes.

How Has This Been Tested?

• test environment:
• test case 1:
• test case 2:
• ...

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

0.0% Coverage
0.0% Duplication

[micbar]

Nice catch!

[phil-davis]

@IljaN @butonic what to do about a changelog in core?
What can be written about this from the PoV of core?

[IljaN]

@phil-davis I'll take care, merged a bit too early. Sorry.