Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust installation database details #40348

Merged
merged 1 commit into from
Nov 14, 2022
Merged

Adjust installation database details #40348

merged 1 commit into from
Nov 14, 2022

Conversation

phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Sep 8, 2022

Description

  1. Remove the space from localhost: 5432 on the installation screen. Note: this changes a translated string, so it can't get into 10.11 - the change needs to go into master and wait a bit for all the language translations to be updated.

  2. TBD - improve PostgreSQL hint - this can be done in a next PR when we know what text to write.

Related Issue

#39871

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis phil-davis self-assigned this Sep 8, 2022
@phil-davis phil-davis marked this pull request as draft September 8, 2022 09:59
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mmattel
Copy link
Contributor

mmattel commented Nov 10, 2022

Any update?

@phil-davis phil-davis marked this pull request as ready for review November 14, 2022 04:46
@phil-davis
Copy link
Contributor Author

Any update?

I rebased and put this change out for review.

@jnweiger #39871 (comment)
what exactly should be written for a PostgreSQL hint?
I am not familiar with PostgreSQL.

@jvillafanez
Copy link
Member

I guess parameterizing the example is too much taking into account we shouldn't change it too often and it won't solve the translation problem....

@jvillafanez
Copy link
Member

I am not familiar with PostgreSQL.

Isn't it smart enough to use the default port for PostgreSQL? I thought you need to provide the port if you aren't using the default one.

@phil-davis phil-davis merged commit b0d4a12 into master Nov 14, 2022
@delete-merged-branch delete-merged-branch bot deleted the issue-39871 branch November 14, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants