Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files_external mount config will show group displaynames #40412

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

jvillafanez
Copy link
Member

Description

Group ids were being shown in the "available for" selection of the files_external mount point configuration. This happens due to recent changes in the user_ldap app and OC 10.11

This PR shows the displayname instead, making eaiser for the admin to select the right group

Related Issue

#40404

Motivation and Context

Since recently, the user_ldap app uses the objectuid (or similar attributes) as group id. Previously, the app used the "cn" attribute.
Anyway, using the displayname for visualizing the list makes more sense.

How Has This Been Tested?

  1. Setup an OC 10.11 and user_ldap 0.17.0 with default configuration. Make sure there are ldap groups available
  2. Go to the settings -> admin storages, and click and the "available for" select.

The list includes groups showing their configured displayname (the "cn" attribute for ldap groups, but default)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Oct 10, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@jvillafanez
Copy link
Member Author

I thought we have a new user_ldap release with owncloud/user_ldap#748 , but it seems it didn't happen yet. I probably was using an unreleased version.

Copy link
Contributor

@mrow4a mrow4a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just wonder why this was GID in the past.. but as there is no comment in the code, I find this change legit.

@jvillafanez
Copy link
Member Author

I think the group displayname wasn't available from the beginning. It was added later.
For local groups, the gid and the displayname is the same, and for ldap, the cn attribute was used as gid, which is very visible. I guess nobody noticed because nobody was using some internal name like the entryuuid as gid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants