Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permissions for link shares depending on a group share won't be updated #40420

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Permissions for link shares depending on a group share won't be updated #40420

merged 2 commits into from
Oct 18, 2022

Conversation

jvillafanez
Copy link
Member

Description

Skip public links when updating permissions of share's children

Related Issue

https://github.com/owncloud/enterprise/issues/5423

Motivation and Context

Currently, updates to permissions of a share are wrongly propagated to public links children.

How Has This Been Tested?

Manually tested following the steps in the linked ticket

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Oct 13, 2022
@jvillafanez jvillafanez mentioned this pull request Oct 13, 2022
Closed
11 tasks
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pako81
Copy link

pako81 commented Oct 13, 2022

@jvillafanez grab some reviewers?

IljaN
IljaN approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@IljaN IljaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pako81
Copy link

pako81 commented Oct 17, 2022

merge it?

@jvillafanez jvillafanez merged commit 66c0c8b into master Oct 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix_group_link_permissions branch October 18, 2022 06:44
@owncloud owncloud deleted a comment from update-docs bot Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@jvillafanez jvillafanez

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jvillafanez @pako81 @IljaN