[full-ci] Files and folder won't be deleted from the "shared with others" section

[jvillafanez]

Description

The "delete" action from the "shared with others" section might be confusing because it will delete the file or folder instead of unsharing it.
Unsharing might also be problematic as action because the file or folder might be shared with multiple people, or it could also be shared by link. Unsharing might mean that all of those connections will be removed, which might include or not the links. This also seems confusing.

The plan is to remove the delete action from that section.
If the user wants to unshare, he can access to the details view of the file and folder, so he can have all the controls he needs there.
Deleting seems clearer in the "all files" section

Related Issue

https://github.com/owncloud/enterprise/issues/5399

Motivation and Context

How Has This Been Tested?

1. userA shares a folder with some content to userB
2. userA goes to the "shared with others" section
3. there isn't any "delete" action to delete the shared folder inside the "shared with others" section.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Database schema changes (next release will require increase of minor version instead of patch)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests only (no source changes)

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:
• Changelog item, see TEMPLATE

[ownclouders]

💥 Acceptance tests pipeline apiTranslation-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37682/71

[jvillafanez]

The test fails because the action isn't available any longer.

[jvillafanez]

@phil-davis should we remove the failing tests now that they aren't applicable any longer, or should we skip them somehow?

[jvillafanez]

ping

[pako81]

@phil-davis can we do something for the failing tests?

[phil-davis]

Sorry for forgetting about this one. I reabsed and put full-ci in the PR title. I will check the CI results to see what is failing. Probably I will just remove the test scenarios that are no longer relevant.

[phil-davis]

There was already a useful acceptance test step that could do:

But it should not be possible to delete file "lorem.txt" using the webUI

So I adjusted the webUI acceptance test scenarios so that they actually check that there is no functional Delete option available.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

42.9% Coverage
0.0% Duplication

[jnweiger]

Confirmed fixed in 10.12.0-rc.3
There is no delete or unshare in the shared with others tab. Not for normal folders, not for WND, SFTP mounts or subfolders thereof.