Allow to temporarily ignore invalid federated shares in tightly federated setup #40503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrow4a should we move this forward? |
mrow4a
force-pushed
the
e5427-feature/fed-setup
branch
from
454dfd3 to
a3fe4d4
Compare
mrow4a
changed the title
mrow4a
force-pushed
the
e5427-feature/fed-setup
branch
from
a3fe4d4 to
88cb220
Compare
pako81
reviewed
Dec 20, 2022
pako81
approved these changes
Dec 20, 2022
|
Apart from a small remark about comments, LGTM 👍 |
mrow4a
force-pushed
the
e5427-feature/fed-setup
branch
from
88cb220 to
7f2c57b
Compare
mrow4a
force-pushed
the
e5427-feature/fed-setup
branch
from
7f2c57b to
c30556b
Compare
|
SonarCloud Quality Gate failed. |
|
@pako81 sonar coverage is hard to do with this class, would need some refactor. would need force-merge still |
|
Needs documentation in our admin docs, pls file an issue in the |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/owncloud/enterprise/issues/5427
Currently, if federated share is invalid or api endpoint returns not found, availability check would validate whether this is a problem with a server and if checks complete that given share is removed. However, in some cases these checks might not be enough (e.g. complex migrations in tightly federated setups), and in that case invalidation behaviour can be disabled using below app setting:
Then instead of removal below warning is displayed
This PR also improves handling and logging to better debug the situation