Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] Add Webdav Token endpoint by App Passwords #40509

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

T0mWz
Copy link
Contributor

@T0mWz T0mWz commented Nov 23, 2022

Description

Add a link to the webdav endpoint by the App Passwords.

Motivation and Context

Show all necessary information of this page, how to use your webdav app passwords.

How Has This Been Tested?

  • Applied to own ownCloud instances

Screenshots (if appropriate):

Screenshot 2022-11-23 at 10 20 43

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

Todo:

  • Add to translation
  • Fix nasty newline

@update-docs
Copy link

update-docs bot commented Nov 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@CLAassistant
Copy link

CLAassistant commented Nov 23, 2022

CLA assistant check
All committers have signed the CLA.

@mmattel
Copy link
Contributor

mmattel commented Jan 30, 2023

@phil-davis can you restart CI ?

@phil-davis
Copy link
Contributor

I rebased and force-pushed.

@phil-davis phil-davis self-assigned this Jan 31, 2023
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUIMobileSize-3-1-chrome-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/37790/164

@phil-davis phil-davis changed the title Add Webdav Token endpoint by App Passwords [full-ci] Add Webdav Token endpoint by App Passwords Jan 31, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

72.6% 72.6% Coverage
1.7% 1.7% Duplication

@mmattel
Copy link
Contributor

mmattel commented Jan 31, 2023

A changelog entry is needed.

@DeepDiver1975
Copy link
Member

A changelog entry is needed.

will do a follow up PR for this

@DeepDiver1975 DeepDiver1975 merged commit cde24aa into owncloud:master Feb 2, 2023
DeepDiver1975 added a commit that referenced this pull request Feb 2, 2023
DeepDiver1975 added a commit that referenced this pull request Feb 2, 2023
@jnweiger
Copy link
Contributor

jnweiger commented Mar 3, 2023

Confirmed fixed in 10.12.0-rc.2
Afaik we have two flavours of the webdav api:

  1. (as advertised on the admin web UI) remote.php/dav/files/
  2. (as used here) remote.php/webdav (with username taken from authorization)

Afaik, 1) is the new API, and 2 is the old API.
@T0mWz why do we advertise the 'old' API here? -- Or am I mistaken here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants