Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share into share move scenario #40612

Merged
merged 3 commits into from
Feb 22, 2023
Merged

Fix share into share move scenario #40612

merged 3 commits into from
Feb 22, 2023

Conversation

pako81
Copy link

@pako81 pako81 commented Jan 31, 2023 •
edited
Loading

Description

Scenario:

Given three users Alice, Bob and Charlie.

Alice shares a folder X with Bob.
Bob shares a file Y with Charlie.
Bob shares a file Z via a public link.

Bob moves Y and Z into the shared folder X.

What is expected:

Alice becomes owner of the files Y and Z.
The share for Charlie on Y and the public link on Z become visible to both Alice and Bob.

What happens:

Alice becomes owner of the files Y and Z.
The share for Charlie on Y becomes visible to Alice and Bob.
The public link on Z is only visible to Bob, not visible to Alice. Owner is not updated to Alice.

Related Issue

Motivation and Context

Public links are lost upon moving share into another share as the share owner is not correctly set.

How Has This Been Tested?

Manually by reproducing the scenario above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@IljaN FYI.

@pako81 pako81 added this to the development milestone Jan 31, 2023
@pako81 pako81 self-assigned this Jan 31, 2023
@pako81 pako81 changed the title Fix share into share move scenarios Fix share into share move scenario Feb 20, 2023
@pako81 pako81 marked this pull request as ready for review February 20, 2023 17:16
@pako81
Copy link
Author

pako81 commented Feb 20, 2023 •
edited
Loading

In case we want to have this partial simple fix for 10.12.0.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Feb 21, 2023
@pako81
Copy link
Author

pako81 commented Feb 22, 2023

@jvillafanez @phil-davis are you ok with merging this?

@pako81 pako81 merged commit b1f8630 into master Feb 22, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_move_share_to_share branch February 22, 2023 11:38
@phil-davis
Copy link
Contributor

What to do about tests? There is some change (improvement) in behavior, so there should be a test that would have failed previously and now passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@IljaN IljaN IljaN approved these changes

@phil-davis phil-davis Awaiting requested review from phil-davis

Assignees

@pako81 pako81

Labels
3 - To Review
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.
4 participants
@pako81 @phil-davis @IljaN @jvillafanez