Adjust parameters for guzzle7 #40652

jvillafanez · 2023-02-22T17:17:29Z

Description

Fixes some bugs caused by the guzzle upgrade

I'm not sure about the federated sharing notifications. Request should reach the server, but I had problems with the share. I don't know if there is a bug lurking around, or it was caused by any of my changes in order to trigger the behavior. Anyway, it seems out of scope.
I assume this was left because the default behavior is to use OCM, not the old mechanism. With OCM, the parameters use "json", so there is no problem.
The federation background job seems awkward and likely untested. That's a bug that is now fixed
For the HTTPHelper, I think it's deprecated and it's only used in the old sharing 1.0. I don't think we use sharing 1.0 anywhere. It seems dead code, but anyway, the issue with guzzle should be fixed, although not tested.

So it seems the only real bug, at least in core, is with the background job of the federation app. The other 2 shouldn't trigger.

Related Issue

#40649

Motivation and Context

Issue with the background job needs to be fixed. There is also comments that needs to be updated.

How Has This Been Tested?

Manually tested except the one for the HTTPHelper, which is a blind change.

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

update-docs · 2023-02-22T17:17:33Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.