Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert logic to expose free_space, but keep availableStorage config #40674

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

phil-davis
Copy link
Contributor

This is a copy of PR #40669 with just 1 commit and targeted to release-10.12.0

The original PR text was:

The issue here is that originally when doing #40389 I somehow mixed the storage_id for S3 bucket with the user urns storage_id's . So when matching with filecache I though it represents that one.

However I was wrong, and used the wrong storage .. also the correct filecache entry for the entire bucket is always showing 0 size.

In this PR, I just expose the config entry for availableStorage, so that apps could use it. Please note that this PR reverts logic to expose this on storage level, so all "quota" calculations wont work. If we want to make it work on storage level, something like background job that calculates this size would need to be done. However, metrics app does not require that complexity and it can simply just use that parameters as in https://github.com/owncloud/metrics/pull/159

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@pako81
Copy link

pako81 commented Mar 7, 2023

nothing more to be done, right? merge this?

@phil-davis phil-davis merged commit 5b21b64 into release-10.12.0 Mar 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix-core-40665-10.12 branch March 7, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants