Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 32bits quota release #40729

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Fix 32bits quota release #40729

merged 6 commits into from
Apr 6, 2023

Conversation

jvillafanez
Copy link
Member

Description

See #40727 . This is the same PR but it targets the release branch. The changes have been cherry-picked.

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Apr 5, 2023
@update-docs
Copy link

update-docs bot commented Apr 5, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jvillafanez jvillafanez mentioned this pull request Apr 5, 2023
Closed
11 tasks
@ownclouders
Copy link
Contributor

ownclouders commented Apr 5, 2023 •
edited
Loading

💥 Acceptance tests pipeline cliEncryption-mariadb10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38217/114

@DeepDiver1975
Copy link
Member

release branch is testing with encryption master which no longer has this command.

suggestion: test release with latest encryption version as per marketplace

Screenshot from 2023-04-05 18-05-22

@jnweiger jnweiger mentioned this pull request Apr 5, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
20.0% 20.0% Duplication

@jnweiger jnweiger requested a review from pako81 April 6, 2023 13:58
@jnweiger jnweiger merged commit 52dcf61 into release-10.12.1 Apr 6, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_32bits_quota_release branch April 6, 2023 14:01
phil-davis pushed a commit that referenced this pull request Apr 17, 2023
@jvillafanez @jnweiger @phil-davis
Fix 32bits quota release (#40729)
3ea0df1 
* Fix quota for 32 bits. Some vars could be float instead of integer

* Include float type in phpdocs

* force downgrading encryption to 1.5.3 in .drone.star, this branch is intended to be shipped with 1.5.3

---------

Co-authored-by: Juergen Weigert <jnweiger@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pako81 pako81 pako81 approved these changes

Assignees

@jvillafanez jvillafanez

Labels
3 - To Review Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jvillafanez @ownclouders @DeepDiver1975 @pako81 @jnweiger