Do not correct parent folders if the target isn't fully scanned #40730

jvillafanez · 2023-04-05T15:32:03Z

Description

If the folder we want to correct the size isn't fully scanned, there is no need to try to correct the parent folders: we can't get a proper size so they should stay as "need to scan" or "shallow scanned".

This should improve the performance a bit when the system isn't fully scanned, specially in deep folders, because we won't try to update all the parent folders unless it's needed.

Related Issue

https://github.com/owncloud/enterprise/issues/5605

Motivation and Context

This should reduce the DB load in some scenarios because there will be less queries to be done.

How Has This Been Tested?

Prepare an external storage (SFTP for example) with "/f1/f2/f3/f4/file.txt"
Connect ownCloud to the external storage
Check that the "/SFTP" folder shows "pending" as size.
Traverse the directories until you reach "/SFTP/f1/f2/f3/f4/file.txt"
From there, traverse the directories backwards. Old "pending" sizes for the folders should show now the right size (assuming there are no additional folders you haven't traversed, such as "/SFTP/f1/f2/side_quest/")

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

update-docs · 2023-04-05T15:32:07Z

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.