Hide last log in column if disabled #40771

phil-davis · 2023-05-04T07:12:57Z

Description

When the Users page is first displayed, if the "Show last log in" setting is off, the hide the "Last Login" column.

1st commit adds 2 new acceptance test scenario, the 2nd scenario fails before the fix.

2nd commit fixes the issue and the tests pass.

Related Issue

Fixes https://github.com/owncloud/enterprise/issues/5711

How Has This Been Tested?

CI and manual check.

admin browses to the users page
turn off "Show last login" - the Last Login column disappears - good.
Browse away to the Files page, then back to the Users page

Before the fix: "Last Login" column is shown, but the checkbox is off - bad.

fter the fix: "Last Login" column is not shown - good.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Database schema changes (next release will require increase of minor version instead of patch)
Breaking change (fix or feature that would cause existing functionality to change)
Technical debt
Tests only (no source changes)

Checklist:

phil-davis · 2023-05-04T07:17:59Z

settings/js/users/users.js

@@ -1108,6 +1108,8 @@ $(document).ready(function () {

 	if ($('#CheckboxLastLogin').is(':checked')) {
 		$("#userlist .lastLogin").show();
+	} else {
+		$("#userlist .lastLogin").hide();


This fixes the issue. But I also tested other checkbox settings like "Show Creation Time". The setting of that works fine when browsing away and back, or logging out and logging in again. But the CheckboxCreationTime code here in users.js does not have the else that I have added here for CheckboxLastLogin. So I do not understand completely - I was expecting CheckboxCreationTime to have the same issue, but it does not have the issue.