Skip to content

Align to new Google authorization URI #40783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 12, 2023
Merged

Align to new Google authorization URI #40783

merged 3 commits into from
May 12, 2023

Conversation

pako81
Copy link

@pako81 pako81 commented May 11, 2023

Description

Align to new Google authorization URI in order to make GDrive integration working again.

Related Issue

Motivation and Context

Core 10.12.1 brought an update of the google/apiclient from version 2.12.6 to 2.13.1. However, in version 2.13.0 the accounts.google.com authorization URI has been updated. This change breaks old code that uses setApprovalPrompt('force') instead of the newer setPrompt('consent') method, as this endpoint does not support the legacy approval prompt parameter.

Sources:

How Has This Been Tested?

Manually on a fresh or updated 10.12.1 instance. Without this fix new GDrive external storages cannot be mounted, with it integration is working again.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 self-assigned this May 11, 2023
@pako81 pako81 added this to the development milestone May 11, 2023
@owncloud owncloud deleted a comment from update-docs bot May 11, 2023
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline apiProxySmoke-8-4-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38421/174

@pako81
Copy link
Author

pako81 commented May 11, 2023

@phil-davis

./tests/acceptance/run.sh --type api
Script path: /drone/src/tests/acceptance
curl: (6) Could not resolve host: proxy
Server on http://proxy is down or not working correctly.
make: *** [Makefile:211: test-acceptance-api] Error 98

@phil-davis
Copy link
Contributor

https://drone.owncloud.com/owncloud/core/38421/174/3
The "proxy" step took 73 seconds to get going. I suppose there is some timing problem there - the acceptance test step started before the proxy was really available.

I restarted CI.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pako81
Copy link
Author

pako81 commented May 11, 2023

@DeepDiver1975 are you ok with this change?

Copy link
Contributor

@jnweiger jnweiger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the patc with both, an upgrade to 10.12.1 and a fresh installed 10.12.1
This fixed the issue in both cases for me.

Thanks.

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have locally checked with this change if things are working again - confirmed, all ok 👍

@IljaN IljaN self-requested a review May 12, 2023 09:50
@pako81 pako81 merged commit fdba492 into master May 12, 2023
@delete-merged-branch delete-merged-branch bot deleted the gdrive-fix branch May 12, 2023 10:30
shokri-navid pushed a commit to pondersource/core that referenced this pull request Jul 16, 2023
* align to new authorization URI

* add changelog

* add links in changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants