-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Align to new Google authorization URI #40783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
💥 Acceptance tests pipeline apiProxySmoke-8-4-maria10.2-php7.4 failed. The build has been cancelled. |
|
https://drone.owncloud.com/owncloud/core/38421/174/3 I restarted CI. |
Kudos, SonarCloud Quality Gate passed! |
@DeepDiver1975 are you ok with this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the patc with both, an upgrade to 10.12.1 and a fresh installed 10.12.1
This fixed the issue in both cases for me.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have locally checked with this change if things are working again - confirmed, all ok 👍
* align to new authorization URI * add changelog * add links in changelog
Description
Align to new Google authorization URI in order to make GDrive integration working again.
Related Issue
invalid token format
#40777Motivation and Context
Core 10.12.1 brought an update of the google/apiclient from version 2.12.6 to 2.13.1. However, in version 2.13.0 the accounts.google.com authorization URI has been updated. This change breaks old code that uses
setApprovalPrompt('force')
instead of the newersetPrompt('consent')
method, as this endpoint does not support the legacy approval prompt parameter.Sources:
How Has This Been Tested?
Manually on a fresh or updated 10.12.1 instance. Without this fix new GDrive external storages cannot be mounted, with it integration is working again.
Types of changes
Checklist: