Skip to content

Add loginInOwnCloud to Log::$methodsWithSensitiveParameters #40792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

pako81
Copy link

@pako81 pako81 commented May 16, 2023

Description

loginInOwnCloud contains sensitive data in the argument list and needs therefore to be added to the list of methods where sensitive parameters are being obfuscated.

How Has This Been Tested?

  • manually

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone May 16, 2023
@pako81 pako81 requested review from jvillafanez and phil-davis May 16, 2023 15:03
@pako81 pako81 self-assigned this May 16, 2023
@pako81
Copy link
Author

pako81 commented May 16, 2023

Not sure if unit tests are needed.

Pasquale Tripodi added 2 commits May 16, 2023 17:06
@owncloud owncloud deleted a comment from update-docs bot May 16, 2023
@ownclouders
Copy link
Contributor

💥 Acceptance tests pipeline webUISharingExt1-git-chrome-maria10.2-php7.4 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/core/38459/156

@phil-davis
Copy link
Contributor

I restarted CI - let's see if it passes this morning.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@phil-davis phil-davis merged commit 7713e0a into master May 17, 2023
@delete-merged-branch delete-merged-branch bot deleted the add-loginInOwnCloud-to-methodsWithSensitiveParameters branch May 17, 2023 05:04
DeepDiver1975 pushed a commit that referenced this pull request May 25, 2023
…sWithSensitiveParameters

Add loginInOwnCloud to Log::$methodsWithSensitiveParameters
@phil-davis phil-davis mentioned this pull request Jun 7, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants