Skip to content

Add commands to handle the trusted servers from command line #40796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 5, 2023
Merged

Add commands to handle the trusted servers from command line #40796

merged 5 commits into from
Jun 5, 2023

Conversation

jvillafanez
Copy link
Member

@jvillafanez jvillafanez commented May 17, 2023 •
edited
Loading

Description

New commands to handle trusted servers from the command line

Related Issue

https://github.com/owncloud/enterprise/issues/5731

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this May 17, 2023
@jvillafanez jvillafanez force-pushed the trusted_servers_cli_handling branch from 4ecdb3d to 21f675c Compare May 17, 2023 15:29
@jvillafanez jvillafanez marked this pull request as ready for review May 17, 2023 16:15
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from ownclouders May 18, 2023
@owncloud owncloud deleted a comment from update-docs bot May 18, 2023
@phil-davis phil-davis self-requested a review May 18, 2023 08:06
phil-davis
phil-davis approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I suppose that others should also review this.

@pako81
Copy link

pako81 commented May 18, 2023

Apart from a small remark for the remove command, it looks ok to me 👍

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

95.3% 95.3% Coverage
0.0% 0.0% Duplication

@mrow4a
Copy link
Contributor

mrow4a commented May 26, 2023 •
edited
Loading

@jvillafanez have a look also in #40815 and https://github.com/owncloud/enterprise/issues/5731#issuecomment-1564065592

@pako81
Copy link

pako81 commented May 26, 2023

merge this?

@pako81 pako81 merged commit 1624c63 into master Jun 5, 2023
@delete-merged-branch delete-merged-branch bot deleted the trusted_servers_cli_handling branch June 5, 2023 08:58
shokri-navid pushed a commit to pondersource/core that referenced this pull request Jul 16, 2023
@jvillafanez
Add commands to handle the trusted servers from command line (ownclou…
05a1d82 
…d#40796)

* Add commands to handle the trusted servers from command line

* Add changelog entry

* Add unit tests

* Improve messages

* Add additional message
@mmattel mmattel mentioned this pull request Aug 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@pako81 pako81 pako81 approved these changes

@mrow4a mrow4a mrow4a approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@jnweiger jnweiger Awaiting requested review from jnweiger

Assignees

@jvillafanez jvillafanez

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jvillafanez @pako81 @mrow4a @phil-davis