Add commands to handle the trusted servers from command line - #40796
Merged
Conversation
jvillafanez
force-pushed
the
trusted_servers_cli_handling
branch
from
May 17, 2023 15:29
4ecdb3d to
21f675c
Compare
phil-davis
reviewed
May 18, 2023
phil-davis
self-requested a review
May 18, 2023 08:06
phil-davis
approved these changes
May 18, 2023
phil-davis
left a comment
phil-davis
left a comment
Contributor
There was a problem hiding this comment.
LGTM - I suppose that others should also review this.
pako81
approved these changes
May 18, 2023
|
Apart from a small remark for the remove command, it looks ok to me 👍 |
phil-davis
approved these changes
May 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Contributor
|
@jvillafanez have a look also in #40815 and https://github.com/owncloud/enterprise/issues/5731#issuecomment-1564065592 |
mrow4a
approved these changes
May 26, 2023
|
merge this? |
shokri-navid
pushed a commit
to pondersource/core
that referenced
this pull request
Jul 16, 2023
…d#40796) * Add commands to handle the trusted servers from command line * Add changelog entry * Add unit tests * Improve messages * Add additional message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New commands to handle trusted servers from the command line
Related Issue
https://github.com/owncloud/enterprise/issues/5731
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: