Skip to content

fix: verify tag name length upon creation #40804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2023

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented May 22, 2023

Description

There is currently no input validation on the length of the tag name.
On a system using sqlite this can result in super long tag names and can result in crashes all over the place. But it is sqlite - not production critical.
On systems using other dbs we see the data being cut of (potentially exceptions?) which does not lead to crashes.

Never the less proper input validation is the way

How Has This Been Tested?

  • 🤖

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the fix/input-validation-tag-creation branch from 06824ac to a8220e9 Compare May 22, 2023 20:04
@DeepDiver1975 DeepDiver1975 force-pushed the fix/input-validation-tag-creation branch from a8220e9 to f1564fc Compare May 23, 2023 09:54
@owncloud owncloud deleted a comment from update-docs bot May 23, 2023
@DeepDiver1975 DeepDiver1975 force-pushed the fix/input-validation-tag-creation branch from f1564fc to e41732d Compare May 23, 2023 10:29
@DeepDiver1975
Copy link
Member Author

Is there an issue for this? (not essential)
Or a link to somewhere that this problem has been discussed?

description updated to give more context - THX

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@DeepDiver1975 DeepDiver1975 merged commit db0f939 into master May 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/input-validation-tag-creation branch May 23, 2023 11:13
shokri-navid pushed a commit to pondersource/core that referenced this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants