make sure to use json for federation post and get #40815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
11 tasks
|
Kudos, SonarCloud Quality Gate passed! |
jvillafanez
approved these changes
May 26, 2023
If this depends on the guzzle version, the affected OC versions should be 10.11.x and 10.12.x . It should be irrelevant for earlier versions. |
shokri-navid
pushed a commit
to pondersource/core
that referenced
this pull request
Jul 16, 2023
* make sure to use json for federation post and get * add changelog * minor fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After update of guzzle , it was no longer possible to request format of response to be json when adding in query parameter. Because default OCSController method assigns xml https://github.com/owncloud/core/blob/v10.12.0/lib/public/AppFramework/OCSController.php#L143-L146 , it was returning XML, but
apps/federation/lib/Controller/OCSAuthAPIController.phpexpects JSON.Now exchange is correctly performed, and servers are marked "green"
WARNING: the patch/fix needs to be applied on all federated severs that are not yet "paired" and have the issue with guzzle library. Otherwise pairing will not work.
Remarks:
Related Issue
Types of changes
Checklist: