Enforce 2fa with exclusion groups #40830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvillafanez
force-pushed
the
2fa_enforcement
branch
from
305ef49 to
8dbbb07
Compare
jvillafanez
force-pushed
the
2fa_enforcement
branch
from
cee2870 to
c58dff5
Compare
phil-davis
reviewed
Jun 12, 2023
phil-davis
approved these changes
Jun 12, 2023
|
Kudos, SonarCloud Quality Gate passed! |
mrow4a
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow the admin to enforce 2fa usage. A 2fa app must be installed and enabled, otherwise this setting will be ignored and all the users will able to login normally.
The admin can also exclude certain groups from the 2fa enforcement. The users belonging to those groups won't have the 2fa enforced, but they can still use 2fa if they want.
Related Issue
https://github.com/owncloud/enterprise/issues/5219
Motivation and Context
How Has This Been Tested?
Manually tested along with the "twofactor_totp" app
Screenshots (if appropriate):
Types of changes
Checklist: