Skip to content

Remove sorting of users in js, rely on server side #40840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2023

Conversation

jvillafanez
Copy link
Member

Description

Previously, users where sorted in the server alphabetically (by displayname it seems), and then the js code sort them again by username with a natural sort. This is weird because the next bunch of user might not be added at the bottom of the list as it's expected, and it might appear at the beginning of the list.

We'll rely on the server to sort the results, so the client will just need to append the results at the end of the list.

Related Issue

https://github.com/owncloud/enterprise/issues/5634

Motivation and Context

How Has This Been Tested?

Manually tested

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 2 Code Smells

33.3% 33.3% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jun 15, 2023
@pako81 pako81 self-requested a review July 31, 2023 11:44
@pako81
Copy link

pako81 commented Jul 31, 2023

I guess we should try to get this in the 10.13 release given that owncloud/user_ldap#796 will be included in user_ldap 0.18.0 and that this app version will be bundled in core 10.13. So if we not merge this, anyone using 10.13 + user_ldap 0.18.0 will notice inconsistent behaviour between LDAP groups and all users sort order.

@pako81
Copy link

pako81 commented Aug 1, 2023

@jvillafanez merge this or are tests still needed?

@jvillafanez jvillafanez merged commit 8c98a26 into master Aug 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove_client_sorting branch August 1, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants