Skip to content

Disable online updater for enterprise #40841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2023
Merged

Disable online updater for enterprise #40841

merged 4 commits into from
Jul 10, 2023

Conversation

pako81
Copy link

@pako81 pako81 commented Jun 14, 2023 •
edited
Loading

Description

Online updater is not recommended for Enterprise installations and needs therefore to be automatically disabled in such cases.

How Has This Been Tested?

  • manually by switching between Community and Enterprise edition and checking that the online updater template is changed accordingly (disabled in case of enterprise with an hint about following the manual upgrade procedure).
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised
  • Changelog item

@pako81 pako81 added this to the development milestone Jun 14, 2023
@pako81 pako81 self-assigned this Jun 14, 2023
@pako81 pako81 mentioned this pull request Jun 14, 2023
Closed
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jun 15, 2023
@IljaN
Copy link
Contributor

IljaN commented Jun 19, 2023

Please Squash

@jnweiger jnweiger merged commit 72fa505 into master Jul 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the disable-online-updater-for-enterprise branch July 10, 2023 15:41
@phil-davis
Copy link
Contributor

Note: this had an indent issue in AdminController.php that was failing the current test-php-style.
(But CI passed last month, the style checker did not notice then, it was an older version)
The indent has been fixed in #40868 (see the last commit)

@phil-davis phil-davis mentioned this pull request Jul 11, 2023
Merged
@pako81
Copy link
Author

pako81 commented Jul 11, 2023

@phil-davis thx

shokri-navid pushed a commit to pondersource/core that referenced this pull request Jul 16, 2023
Disable online updater for enterprise (owncloud#40841)
77c16f7 
* disable online updater for enterprise

* add changelog entry

* fix changelog entry

* add changelog entry
@jnweiger
Copy link
Contributor

When saying that the updater is disabled, maybe also link to https://doc.owncloud.com/server/next/admin_manual/maintenance/upgrading/upgrade.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

Assignees

@pako81 pako81

Labels
3 - To Review
Projects
None yet
Milestone
development
Development

Successfully merging this pull request may close these issues.
4 participants
@pako81 @IljaN @phil-davis @jnweiger