Skip to content

Fix error when version_metadata is enabled and there is no quota #40847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix error when version_metadata is enabled and there is no quota #40847

merged 2 commits into from
Jun 26, 2023

Conversation

IljaN
Copy link
Contributor

@IljaN IljaN commented Jun 21, 2023 •
edited
Loading

Description

Fix Exception with Files_Version/ExpireJob.php when receiving a federated share and having 'file_storage.save_version_metadata' enabled.

We fixed by ignoring metadata for fed-shares.

Related Issue

How Has This Been Tested?

✋

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@IljaN IljaN marked this pull request as ready for review June 21, 2023 13:56
@IljaN IljaN requested review from DeepDiver1975, pako81 and mrow4a June 21, 2023 13:56
@IljaN IljaN self-assigned this Jun 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@owncloud owncloud deleted a comment from update-docs bot Jun 22, 2023
@IljaN IljaN merged commit 49921af into master Jun 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix_version_metadata_fedshare branch June 26, 2023 08:47
shokri-navid pushed a commit to pondersource/core that referenced this pull request Jul 16, 2023
@IljaN
Fix error when version_metadata is enabled and there is no quota (own…
006ca5e 
…cloud#40847)

* Fix error when version_metadata is enabled and there is no quota

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@pako81 pako81 Awaiting requested review from pako81

@mrow4a mrow4a Awaiting requested review from mrow4a

Assignees

@IljaN IljaN

Labels
3 - To Review Type:Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IljaN @jvillafanez