Skip to content

fix: properly convert file id with instance postfix to pure id #40958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2023
Merged

fix: properly convert file id with instance postfix to pure id #40958

merged 1 commit into from
Aug 30, 2023

Conversation

DeepDiver1975
Copy link
Member

Description

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@DeepDiver1975 DeepDiver1975 force-pushed the fix/app-registry-fileid-ios-collabora branch from 99e49a8 to 21703cf Compare August 29, 2023 11:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jnweiger jnweiger mentioned this pull request Aug 30, 2023
Closed
@IljaN IljaN assigned IljaN and unassigned IljaN Aug 30, 2023
@IljaN IljaN self-requested a review August 30, 2023 15:23
@owncloud owncloud deleted a comment from update-docs bot Aug 30, 2023
@DeepDiver1975 DeepDiver1975 merged commit af0852c into master Aug 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the fix/app-registry-fileid-ios-collabora branch August 30, 2023 15:34
@michaelstingl michaelstingl mentioned this pull request Aug 31, 2023
Closed
@jnweiger
Copy link
Contributor

jnweiger commented Sep 5, 2023

Confirmed fixed in 10.13.1-rc.1

  • when the user was previously logged in into the Web UI, browser gets redirected to Collabora
  • when the user was not previously logged in, A 'contact admin' error is shown. Not nice, but okayish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IljaN IljaN IljaN approved these changes

Assignees
No one assigned
Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DeepDiver1975 @jnweiger @IljaN