Skip to content

fix: disallow pre-signed url access if the signing key is not initialized - #40962

Merged
DeepDiver1975 merged 1 commit into
masterfrom
fix/empty-sign
Sep 5, 2023
Merged

fix: disallow pre-signed url access if the signing key is not initialized#40962
DeepDiver1975 merged 1 commit into
masterfrom
fix/empty-sign

Conversation

@DeepDiver1975

@DeepDiver1975 DeepDiver1975 commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@owncloud owncloud deleted a comment from update-docs Bot Aug 31, 2023
@phil-davis

phil-davis commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@jnweiger is this to go in 10.13.1?
If so, merge here to master and cherry-pick to the release branch, or rebase this to the release branch?

@DeepDiver1975

DeepDiver1975 commented Aug 31, 2023

Copy link
Copy Markdown
Contributor Author

If so, merge here to master and cherry-pick to the release branch

this way ....

@sonarqubecloud

sonarqubecloud Bot commented Sep 1, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@DeepDiver1975
DeepDiver1975 merged commit 118a4e8 into master Sep 5, 2023
@delete-merged-branch
delete-merged-branch Bot deleted the fix/empty-sign branch September 5, 2023 07:00
@jnweiger

jnweiger commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Confirmed fixed in 10.13.1-rc.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@IljaN IljaN IljaN approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @phil-davis @jnweiger @IljaN