-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't mount shares with failed underlying storages #41014
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Tested following scenarios on 10.13.2 RC1.
|
JP if we could had tests and changelog that would be great |
I guess we should switch this to the |
@phil-davis https://drone.owncloud.com/owncloud/core/39225/171/15 and https://drone.owncloud.com/owncloud/core/39225/173/15 fail but for instance https://drone.owncloud.com/owncloud/core/39225/170/15 goes through. Maybe you have an idea. |
Kudos, SonarCloud Quality Gate passed! |
Maybe we should cherry-pick the commits instead of switching the target branch. There are changes in the Japanese translations that I don't know if they should be there or not. |
I've re-triggerd drone. Those errors are purely sporadic, I got a clean CI run now. |
You are right. The Translation changes in this PR don't look good. Lots of deletions. Let's merge into master and cherry pick from there. |
* Don't mount shares with failed underlying storages * Add and adjust unit tests * Add changelog entry
FYI #40332 - that has been a problem for a long time. @DeepDiver1975 hopes to have fixed it yesterday. The Japanese translations should come back into master in a few hours, and not disappear any more. |
- Bump PORTREVISION for package change Upstream rerolled the tarball to include a bugfix "Do not mount shared storage which are failing". Reference: owncloud/core#41014
Description
Share mounts with failed underlying storages won't be mounted. A common cause of such failure is the underlying storage has been removed or the sharer has been deleted.
This should help the
occ files:remove-storage --show-candidates
command to detect additional storages that should be removed.Related Issue
https://github.com/owncloud/enterprise/issues/6063
Motivation and Context
How Has This Been Tested?
Manually tested.
occ files:remove-storage --show-candidates
now shows the external storageStep 5 might be required in order for ownCloud to notice the unavailable storage.
Screenshots (if appropriate):
Types of changes
Checklist: