Fix issue with LDAP groups in the applicable field #41063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phil-davis
reviewed
Oct 30, 2023
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
Just a few comments on the changelog
jvillafanez
force-pushed
the
applicable_group_displayname
branch
from
bc97b1e to
42ed88b
Compare
jvillafanez
force-pushed
the
applicable_group_displayname
branch
from
42ed88b to
48e1798
Compare
DeepDiver1975
requested changes
Nov 8, 2023
Member
DeepDiver1975
left a comment
DeepDiver1975
left a comment
There was a problem hiding this comment.
Just some remarks on type declarations
DeepDiver1975
requested changes
Nov 8, 2023
apps/files_external/tests/Controller/ApplicableControllerTest.php
Outdated
Show resolved
Hide resolved
jvillafanez
force-pushed
the
applicable_group_displayname
branch
from
2082381 to
1c43b2c
Compare
|
Kudos, SonarCloud Quality Gate passed! |
DeepDiver1975
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The "applicable" field in the external storage configuration wasn't working for LDAP groups. This issue happens on new installations where the configured LDAP attribute for the groupname is the "objectguid" or "entryuid".
Old installations should have the "cn" attribute configured instead, which should match the configured displayname for the group, so the issue shouldn't happen
Related Issue
#41062
Motivation and Context
The "applicable" field should work properly regardless of the LDAP configuration. In particular, the default configuration should work.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: