fix: add support for port number #41237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
|
DeepDiver1975
changed the base branch from
master
to
fix/sharing-external-unreachable-hosts
delete-merged-branch
bot
deleted the
sharing-external-unreachable-hosts-port
branch
DeepDiver1975
added a commit
that referenced
this pull request
Apr 26, 2024
* fix: fail fast if remote is not reachable * fix: error and url handling ... * fix: add dedicated connectivty check * fix: add support for port number (#41237) --------- Co-authored-by: Phil Davis <phil@jankaritech.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is on top of the linked PR.
If I am running the ownCloud federated server(s) on some other port (not on port 80), then the checks for reachability need to include the port number as well as the host. This happens in development, when starting 2 different servers on the same local system for testing, and it could happen in production installs, I suppose.
It is not a problem in CI, because the drone CI configuration starts the 2 test servers in docker containers that have their own host names, and both of them use port 80 at their respective hosts.
Related Issue
PR #41210
How Has This Been Tested?
Types of changes
Checklist: