Skip to content

Conversation

@DeepDiver1975
Copy link
Member

…abled

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented May 10, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jnweiger jnweiger changed the title fix: diallow http api requests for user external storages in case dis… fix: disallow http api requests for user external storages in case dis… Jun 10, 2024
@DeepDiver1975 DeepDiver1975 force-pushed the fix/user-ext-storage-no-ops-if-disabled branch 2 times, most recently from a40b9c3 to 1056a37 Compare June 18, 2024 10:12
@DeepDiver1975 DeepDiver1975 force-pushed the fix/user-ext-storage-no-ops-if-disabled branch from 1056a37 to eb937b4 Compare June 18, 2024 12:37
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
47.8% Coverage on New Code (required ≥ 53%)

See analysis details on SonarCloud

@pako81 pako81 self-requested a review June 20, 2024 15:03
@DeepDiver1975 DeepDiver1975 merged commit 32e12ef into master Jun 20, 2024
@phil-davis phil-davis deleted the fix/user-ext-storage-no-ops-if-disabled branch June 20, 2024 15:49
@phil-davis
Copy link
Contributor

@jnweiger should this also go into release-10.15.0 branch?

@DeepDiver1975
Copy link
Member Author

Yes. Will do a cherry pick tomorrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants