Skip to content

fix: service's paths won't traverse backwards - #41374

Merged
DeepDiver1975 merged 2 commits into
masterfrom
hardening_remote
Jun 26, 2025
Merged

DeepDiver1975 merged 2 commits into
masterfrom
hardening_remote

Conversation

@jvillafanez

Copy link
Copy Markdown
Member

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@jvillafanez jvillafanez self-assigned this Jun 12, 2025
@update-docs

update-docs Bot commented Jun 12, 2025

Copy link
Copy Markdown

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975

Copy link
Copy Markdown
Contributor

@jvillafanez can you please add a changelog item? THX

@DeepDiver1975
DeepDiver1975 merged commit c3c7c5a into master Jun 26, 2025
@jvillafanez
jvillafanez deleted the hardening_remote branch June 26, 2025 08:49
DeepDiver1975 pushed a commit that referenced this pull request Jul 2, 2025
* fix: service's paths won't traverse backwards

* chore: add changelog entry
@UnitedMarsupials

Copy link
Copy Markdown

I'm now getting this warning on every request:

[proxy_fcgi:error] [pid 86760] [client 192.168.1.10:21280] AH01071: Got error 'PHP message: PHP Warning:  stream_wrapper_unregister(): Unable to unregister protocol phar:// in /opt/www/owncloud/lib/kernel.php on line 574'

I had to modify the kernel.php as follows, which helped -- but there ought to be a better way:

--- lib/kernel.php	2025-07-03 09:54:27.000000000 -0400
+++ lib/kernel.php	2025-12-08 12:00:22.079292000 -0500
@@ -571,5 +571,5 @@
 
 		// disable phar handler in web requests
-		if (!self::$CLI) {
+		if (!self::$CLI and in_array('phar', stream_get_wrappers())) {
 			stream_wrapper_unregister("phar");
 		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants