Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable6] [backport] Added .ocdata file to check for data folder validity #7819

Merged
merged 3 commits into from Mar 20, 2014

Conversation

Projects
None yet
9 participants
@PVince81
Copy link
Member

commented Mar 20, 2014

Backport of #7732 to stable6

In environments where the data folder is mount from another partition,
it is important to check that the data folder we see is actually the
real one. If the mount failed for some reasons, this fix will make
ownCloud temporarily unavailable instead of causing unpredictable
behavior.

Please review/test @icewind1991 @jcfischer @DeepDiver1975 @karlitschek

PVince81 added some commits Mar 14, 2014

Added .ocdata file to check for data folder validity
In environments where the data folder is mount from another partition,
it is important to check that the data folder we see is actually the
real one. If the mount failed for some reasons, this fix will make
ownCloud temporarily unavailable instead of causing unpredictable
behavior.

Backport of 3c46dcd from master

@PVince81 PVince81 referenced this pull request Mar 20, 2014

Merged

Added .ocdata file to check for data folder validity #7732

6 of 6 tasks complete
@karlitschek

This comment has been minimized.

Copy link
Member

commented Mar 20, 2014

👍

@PVince81

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2014

Going to retest this to make sure it also works on stable6:

  • Setup creates ".ocdata"
  • Upgrade creates ".ocdata"
  • Manually remove ".ocdata" file to simulate the issue, then recreate it (with sync client running)
  • Test with real FS mount on "data" dir: umount, check, then remount (with sync client running)
  • Run curl to see if 503 is returned correctly
@PVince81

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2014

I wanted to type "myself" and typed "mysql"... strange finger reflexes 😃

@scrutinizer-notifier

This comment has been minimized.

Copy link

commented Mar 20, 2014

The inspection completed: 5 new issues, 10 updated code elements

@PVince81

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2014

Looks like it works fine 😄

@owncloud-bot

This comment has been minimized.

Copy link
Contributor

commented Mar 20, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/3802/

@icewind1991

This comment has been minimized.

Copy link
Member

commented Mar 20, 2014

Looks good 👍

PVince81 added a commit that referenced this pull request Mar 20, 2014

Merge pull request #7819 from owncloud/stable6-datafolderexistence
[stable6] [backport] Added .ocdata file to check for data folder validity

@PVince81 PVince81 merged commit 2c2fd5f into stable6 Mar 20, 2014

1 check passed

default Merged build finished.
Details

@PVince81 PVince81 deleted the stable6-datafolderexistence branch Mar 20, 2014

@blizzz

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2014

This kills my stable6 setup. Terrible update experience.

ocdata

@blizzz

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2014

The data folder is not mounted from anywhere.

@DeepDiver1975

This comment has been minimized.

Copy link
Member

commented Mar 21, 2014

@blizzz I assume you run a git installation - right?

@blizzz

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2014

Never mind, somehow had a wrong version in my config.php :/

@PVince81

This comment has been minimized.

Copy link
Member Author

commented Mar 21, 2014

The quick fix: touch data/.ocdata 😉

@hardiyan46

This comment has been minimized.

Copy link

commented Dec 3, 2016

what shouold i do
ownerror

i move data default on owncloud to another drive (/mnt/DATA/owncloud/data)
please help me
sory my english is bad

@PVince81

This comment has been minimized.

Copy link
Member Author

commented Dec 3, 2016

create the missing file or move it from the old data folder

@mr-bolle

This comment has been minimized.

Copy link

commented Mar 12, 2017

I had the last few days the same problem, no matter what permissions I gave the data directory.
Now I have moved the data directory and re-scan the files (sudo -u www-data php occ files:scan) - after this, all shared shares (link or users / groups) are no longer available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.