New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use high resolution avatars on highdpi screens #8065

Merged
merged 1 commit into from Apr 7, 2014

Conversation

Projects
None yet
7 participants
@icewind1991
Member

icewind1991 commented Apr 4, 2014

More nice looking pictures on high dpi screens :)

cc @jancborchardt @Kondou-ger

@owncloud-bot

This comment has been minimized.

Show comment
Hide comment
@owncloud-bot

owncloud-bot Apr 4, 2014

Contributor

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4086/

Contributor

owncloud-bot commented Apr 4, 2014

🚀 Test Passed. 🚀
Refer to this link for build results: https://ci.owncloud.org/job/pull-request-analyser/4086/

@scrutinizer-notifier

This comment has been minimized.

Show comment
Hide comment
@scrutinizer-notifier

scrutinizer-notifier Apr 4, 2014

The inspection completed: 1 new issues

scrutinizer-notifier commented Apr 4, 2014

The inspection completed: 1 new issues

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Apr 5, 2014

Member

👍 - tested on retina MBP.

Member

LukasReschke commented Apr 5, 2014

👍 - tested on retina MBP.

@jancborchardt

This comment has been minimized.

Show comment
Hide comment
@jancborchardt

jancborchardt Apr 5, 2014

Member

Woah man, really good on the HiDPI updates. :) Check it out @owncloud/designers

Member

jancborchardt commented Apr 5, 2014

Woah man, really good on the HiDPI updates. :) Check it out @owncloud/designers

@blizzz

This comment has been minimized.

Show comment
Hide comment
@blizzz

blizzz Apr 7, 2014

Contributor

Did someone test with IE? Afaik older versions do not support window.devicePixelRatio.

Contributor

blizzz commented Apr 7, 2014

Did someone test with IE? Afaik older versions do not support window.devicePixelRatio.

@DeepDiver1975

This comment has been minimized.

Show comment
Hide comment
@DeepDiver1975

DeepDiver1975 Apr 7, 2014

Member

Tested on chromium and IE8 👍

Member

DeepDiver1975 commented Apr 7, 2014

Tested on chromium and IE8 👍

DeepDiver1975 added a commit that referenced this pull request Apr 7, 2014

Merge pull request #8065 from owncloud/avatar-highdpi
use high resolution avatars on highdpi screens

@DeepDiver1975 DeepDiver1975 merged commit c86bda0 into master Apr 7, 2014

1 check passed

default Merged build finished.
Details

@DeepDiver1975 DeepDiver1975 deleted the avatar-highdpi branch Apr 7, 2014

@icewind1991

This comment has been minimized.

Show comment
Hide comment
@icewind1991

icewind1991 Apr 7, 2014

Member

@blizzz there are fallbacks in place for devicePixelRatio

Member

icewind1991 commented Apr 7, 2014

@blizzz there are fallbacks in place for devicePixelRatio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment