Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement batch action for inviting users to groups #522

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen self-assigned this Jun 22, 2022
@DeepDiver1975 DeepDiver1975 force-pushed the feat/invite-guests branch 2 times, most recently from c148b82 to b5cbf52 Compare June 23, 2022 14:51
@DeepDiver1975 DeepDiver1975 force-pushed the feat/invite-guests branch 2 times, most recently from 4d9c6ab to 809d8f0 Compare June 27, 2022 21:04
@jnweiger jnweiger mentioned this pull request Jul 12, 2022
42 tasks
@JammingBen JammingBen marked this pull request as ready for review July 12, 2022 17:32
@JammingBen
Copy link
Contributor Author

This one is ready for review, sorry for not marking earlier. It needs #521 to be finished and merged first though, otherwise we permanently have merge conflicts with each force push to #521

@phil-davis
Copy link
Contributor

I put this into the Classic Server Team Board project, and mentioned some people for review.

1 JS test failed - I have no idea if that is a real fail.

There is a conflict reported, so that n eeds to be sorted out.

js/MembersInputView.js Outdated Show resolved Hide resolved
continue;
}

// only add new users
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to use a set instead of an array. The operation should be more clear too:

var s = new Set()
s.add(user)  // guarantees uniqueness

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it, unfortunately Sets do not support uniqueness with objects.

js/MembersInputView.js Show resolved Hide resolved
var user = users[i].trim();
var userAdded = false;

for (var j = 0; j < foundUsers.length; j++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above, it seems better to use a set instead of an array

js/MembersView.js Outdated Show resolved Hide resolved
lib/Controller/PageController.php Outdated Show resolved Hide resolved
lib/Service/GuestIntegrationHelper.php Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@DeepDiver1975 DeepDiver1975 merged commit d3ce514 into feat/invite-guests Jul 18, 2022
@delete-merged-branch delete-merged-branch bot deleted the batch-invite-action branch July 18, 2022 13:21
@jnweiger
Copy link
Contributor

Confirmed implemented in 0.7.0-rc.1
image

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants