New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide informations if upgrade from OC 4.5 with encrypted data to OC 5 is possible #78

Closed
ghost opened this Issue Mar 18, 2013 · 11 comments

Comments

Projects
None yet
4 participants
@ghost
Copy link

ghost commented Mar 18, 2013

Hi,

i think there is a very important information missing in the documentation:

Since the old files_encryption app was removed from OC5 and the new files_encryption is not included in the final release of OC 5.0 no informations about an Upgrade with encrypted data is available in the documentation. Are there any chances to get some informations about the upgrade path for this from OC 4.5 to OC 5?

@BernhardPosselt

This comment has been minimized.

Copy link
Contributor

BernhardPosselt commented Mar 18, 2013

You're right, that is indeed a bit complicated. Suggestions @samtuke ?

@samtuke

This comment has been minimized.

Copy link

samtuke commented Mar 19, 2013

So, the unreleased new encryption app will migrate data from older installations, including data which was encrypted with the old app.

I haven't tested 5.0 migration (the encryption app isn't ready/included yet), but I expect that trying to upgrade from 4.x with encryption enabled to 5.0 would result in unreadable data. Therefore we probably need huge warning signs to notify users of this risk, or ideally, simply not allow such upgrades at all (until the new encryption app is released). It might be worth writing a small migration script to check if old encryption is enabled and cease the upgrade attempt if it is, in order to protect against data loss.

@Raydiation have you started your internship yet? Are you able to work on this at all?

Thanks for the report @RealRancor !

@BernhardPosselt

This comment has been minimized.

Copy link
Contributor

BernhardPosselt commented Mar 19, 2013

sure :) im already at it ;)

It might be a bit overkill though to provide another if statement in the installer/updater which might cause additional bugs just to prevent people to update to 5.0 because encryption will be released on a few days.

In general im not sure what the best solution is for now. @RealRancor do you think a simple hint in the documentation might be enough?

@BernhardPosselt

This comment has been minimized.

Copy link
Contributor

BernhardPosselt commented Mar 19, 2013

Documentation in 5.0 is updated.

@samtuke

This comment has been minimized.

Copy link

samtuke commented Mar 19, 2013

It will be more than a few days, more like weeks. So in the mean time there are potentially many users who will try and migrate without any warning. Documenting the issue is the absolute minimum IMO, but really we should actively prohibit users from doing anything that could cause dataloss such as this :/

@ghost

This comment has been minimized.

Copy link

ghost commented Mar 19, 2013

Hi,

thanks for this informations.

In general im not sure what the best solution is for now. @RealRancor do you think a simple hint in the documentation might be enough?

@Raydiation
Mhhh, good questions. I don't know how many users will read the documentation before the update / upgrade. Probably not very much and then they will have the dataloss as pointed out by @samtuke

@danimo

This comment has been minimized.

Copy link
Contributor

danimo commented Mar 19, 2013

We can safely assume that people will not read the documentation thoroughly enough. We need to warn about this in the installation since this effectively means a loss of data (access), right?

@samtuke

This comment has been minimized.

Copy link

samtuke commented Mar 19, 2013

@danimo Yes, as far as I can see. I had nothing to do with the release process, and wasn't consulted about how encryption was removed, so it's possible I'm missing something, or that there is some kind of safety net. But from where I'm sitting it looks like no encryption support at all ships with OC5.0, and therefore users upgrading from 4.x will find any data that was previously encrypted becomes unreadable. Recovering data in such a scenario is no doubt possible, but potentially also very time consuming.

@samtuke

This comment has been minimized.

Copy link

samtuke commented Mar 19, 2013

I recommend that someone test this - I'm not volunteering because I'm under time pressure to get the new encryption app ready

@vguna

This comment has been minimized.

Copy link

vguna commented Apr 4, 2013

Thanks. That means all my data is now lost? Simply updated using apt-get upgrade. I NEVER lost any data upgrading ANY other app via apt. Never.

@BernhardPosselt

This comment has been minimized.

Copy link
Contributor

BernhardPosselt commented Apr 4, 2013

@vguna see response in owncloud/core#2666

BernhardPosselt added a commit that referenced this issue Apr 8, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment