-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drop setup of user based encryption #389
Conversation
97d2af7
to
ea3b905
Compare
ea3b905
to
819e5e4
Compare
819e5e4
to
fd6e912
Compare
💥 Acceptance tests pipeline apiMasterKeys-latest-mysql8.0-php7.4 failed. The build has been cancelled. |
💥 Acceptance tests pipeline cliEncryption-latest-postgres9.4-php7.4 failed. The build has been cancelled. |
@DeepDiver1975 I did similar investigation in #388 , as you already created PR might be worth to crosscheck with my PR, because I see few parts are different in your way. One remark: I think we cannot have none of the modules enabled. At least one needs to be auto-enabled. Otherwise it would require too much hacking. But I think in your PR you enable master-key encryption by default right ? |
Yes. As soon as encryption is enabled and the encryption app is enabled as well master key is enabled as well. |
Also I think it would be worth to add this block to inform about depreciation
|
Feel free to push it to this branch |
@DeepDiver1975 added a commit that cleans a bit the backwards compatible flow and adds the decpreciation note for user-key |
https://drone.owncloud.com/owncloud/encryption/2971/6/5
|
Code looks good. For support and regression testing, do we still want some way to create an oC10 install with user-key encryption? For example, support is investigating some issue with a production installation somewhere and wants to try and reproduce the problem. How can the support team startup a test oC10, and enable encryption with user-key? And as long as we still support user-key encryption, then we want to avoid accidentally introducing regressions. So it would be good t have some way that a test environment (preferably automated) can enable user-key encryption and then run the test suite (and/or some manual tests). Maybe it is as easy as:
setting that app config value to 1, and "it will just happen"? |
Kudos, SonarCloud Quality Gate passed! |
@phil-davis I think user-key was deprecated in 10.7, which was very long ago. I think it is fair to stop testing it by now already. |
10.7 was release 2 years ago - long enough .... let it die .... |
No description provided.