CSS isn't loaded correctly in ownCloud 9 version of the player #36

Closed
Instagit opened this Issue Mar 9, 2016 · 9 comments

Projects

None yet

4 participants

@Instagit
Collaborator
Instagit commented Mar 9, 2016

The player looks like this:
1

It should look like this:
2

For some reason not all CSS is applied. When you install the old app (VideoJS Sublime) from the app menu, it works.

@Instagit Instagit added the bug label Mar 9, 2016
@Instagit
Collaborator
Instagit commented Mar 9, 2016

It's because of this change.

"techOrder": ["html5"]

is causing the behaviour. Is there a reason this was added? Flash fallback was removed so I don't think we need this option.

@jancborchardt
Member

@Instagit can you open a pull request with that fix? We should then also backport this because otherwise it doesn’t blend in with ownCloud’s nice design. cc @karlitschek

@jancborchardt
Member

@LukasReschke you added this attribute with 73dff41 – any specific reason for that?

@LukasReschke
Member

@LukasReschke you added this attribute with 73dff41 – any specific reason for that?

Basically to disable the Flash fallback completely as per http://stackoverflow.com/questions/15508563/disable-flash-in-video-js

Changing it back won't be terrible bad as it is not used in newer browsers anyways. But I really wonder why this has an effect on the CSS. This seems pretty strange 😕

@Instagit
Collaborator
Instagit commented Mar 9, 2016

It causes an error not directly with the CSS, but with the VideoJS initialization and that affects the entire element. CSS classes are missing etc.

SyntaxError: JSON.parse: end of data while reading object contents at line 1 column 2 of the JSON data

I think it's actually just a syntax error, data-setup needs single quotes. We can let it in and fix it that way. I'll change the css-fix branch and open a pull request.

@karlitschek
Member

backport is fine with me because I assume that is is very limited and simple.

@Instagit Instagit closed this Mar 21, 2016
@jancborchardt
Member

@Instagit thanks for the good catch! And sorry for not having that with ownCloud 9, but the patch release will be all the more awesome. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment