Sharing permissions can't be modified because checkboxes are not shown #538

Closed
oparoz opened this Issue Feb 28, 2016 · 6 comments

Projects

None yet

3 participants

@oparoz
Collaborator
oparoz commented Feb 28, 2016

Bug report

Steps to reproduce

  1. Open an album
  2. Click on the share button
  3. Share with a user

Expected behaviour

In the area where the user which the folder is shared with is shown, there should be checkboxes next to can share, can edit, create, change and delete

Actual behaviour

Checkboxes are not shown which means permissions cannot be modified.

This was introduced when all the checkboxes where changed, starting from 8.2.

By playing with the CSS, we can see that the checkboxes exist; they're just masked.

The checkboxes for the public link section were modified. I'm guessing a similar fix needs to be applied here.

@Henni Henni was assigned by oparoz Feb 28, 2016
@oparoz oparoz added this to the 9.0-current milestone Feb 28, 2016
@oparoz oparoz assigned oparoz and unassigned Henni Feb 28, 2016
@oparoz
Collaborator
oparoz commented Feb 28, 2016

I'll take care of it

@Henni
Member
Henni commented Feb 28, 2016

short hint:
The HTML has to look like <input type="checkbox"><label>[...]</label>.
Only if it is ordered this way the checkbox will be rendered.

@oparoz
Collaborator
oparoz commented Feb 28, 2016

Yeah, I've figured it out by comparing with Files, but thanks for confirming :). There is also a problem with the classes, each input has 2 declarations and the second one is ignored.
The fix will be released as part of the rewrite of the share class.

@oparoz oparoz referenced this issue Feb 29, 2016
Merged

Make share.js work with new OCS Share API #541

21 of 23 tasks complete
@rullzer
Contributor
rullzer commented Mar 1, 2016

Fixed with #541 as far as I can tell. Please reopen if not.

@rullzer rullzer closed this Mar 1, 2016
@oparoz
Collaborator
oparoz commented Mar 1, 2016

I'm re-opening it because this is for 8.2.x. Even though nobody seems to have noticed, it would be nice if it worked as expected.

@oparoz oparoz reopened this Mar 1, 2016
@oparoz oparoz referenced this issue Mar 1, 2016
Merged

[Stable8.2] Restore permission checkboxes #546

5 of 6 tasks complete
@oparoz
Collaborator
oparoz commented Mar 1, 2016

Fixed via #546

@oparoz oparoz closed this Mar 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment