Skip to content
This repository has been archived by the owner. It is now read-only.

Feature request: HEIC support #737

Closed
Emil-G opened this issue Jan 3, 2018 · 8 comments

Comments

@Emil-G
Copy link

commented Jan 3, 2018

The latest Apple format HEIC does not show up as images in Gallery.

@Emil-G Emil-G changed the title HEIC support Feature request: HEIC support Jan 3, 2018

@DeepDiver1975 DeepDiver1975 self-assigned this Jan 9, 2018

@DeepDiver1975 DeepDiver1975 added this to the development milestone Jan 9, 2018

@DeepDiver1975 DeepDiver1975 referenced this issue Jan 10, 2018
4 of 9 tasks complete

@PVince81 PVince81 modified the milestones: development, backlog Jul 18, 2018

@steiny2k steiny2k referenced this issue Aug 27, 2018
3 of 8 tasks complete
@steiny2k

This comment has been minimized.

Copy link

commented Aug 27, 2018

Hi, at least in the Nextcloud codebase this is adressed with
nextcloud/gallery#464 should I try to port it to owncloud/gallery separately, or are the two repos somehow syncronized?

@madsi1m

This comment has been minimized.

Copy link

commented Aug 27, 2018

might be here? /service/configservice.php

@steiny2k

This comment has been minimized.

Copy link

commented Aug 27, 2018

Hi. Sure, it‘s the /service/configservice.php. Just wanted to check whether you are maintaining your own repo for the owncloud gallery or whether this is automagically merged anyhow… but I guess I‘ll just verify it whether the necessary changes are in owncloud core and make another PR to resolve this for owncloud gallery too 😀

@steiny2k

This comment has been minimized.

Copy link

commented Aug 27, 2018

Just verified this in my local development instance. Seems to work in the same way as in nextcloud. So I quickly posted a separate PR (#792).

Happy to take your feedback 😄

@madsi1m

This comment has been minimized.

Copy link

commented Aug 28, 2018

Might be said somewhere else but which version of imagemagick do we need for these files to work?

@steiny2k

This comment has been minimized.

Copy link

commented Aug 28, 2018

Support in ImageMagick was added with this pull request: ImageMagick/ImageMagick#1099
On macOS it can be installed through homebrew:
brew install --with-libheif imagemagick

On FreeBSD you can install libheif through the ports tree and need to patch the ImageMagick port with the changes I reported here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=230788

I think in other linux distros it is similar. If it isn‘t part of your favourite distributions' packages you may as well compile it yourself. When running ./confugure add the parameter --with-libheif and make sure you got libheif from the packages of your distro or compiled from sources:
https://github.com/strukturag/libheif

If you tell me which distros owncloud/nextcloud favours I’m happy to write some docu how to set it up.

@Emil-G

This comment has been minimized.

Copy link
Author

commented Aug 28, 2018

@PVince81 It was my understanding that ImageMagick was dangerous in OC: https://owncloud.org/news/imagetragick-dangerous-for-owncloud-users/ ?

@PVince81

This comment has been minimized.

Copy link
Member

commented Aug 28, 2018

It is dangerous if the installed version has security vulnerabilities and someone uploads a file that exploits them. In the case of that article it mentions a few extensions that were at risk back in 2016, not sure if ImageMagick has fixed the vulnerabilities already. You could disabled said preview providers and only leave PNG and JPG.

The ideal setup would be where the preview generation code is running in a separate server, which isn't implemented yet. See owncloud/core#24424

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.