Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added associated domains to resign script #1028

Merged
merged 2 commits into from Sep 10, 2021

Conversation

mneuwert
Copy link
Contributor

@mneuwert mneuwert commented Sep 8, 2021

Description

Resign script can now inject associated domains into the resigned application's entitlements.

Store a text file domains.txt in the /enterprise/resign folder and run the resign script.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Added changelog files for the fixed issues in folder changelog/unreleased

@mneuwert mneuwert requested a review from hosy September 8, 2021 04:57
@CLAassistant
Copy link

CLAassistant commented Sep 8, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hosy
❌ Michael Neuwert


Michael Neuwert seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@michaelstingl
Copy link
Contributor

@NannaBarz could you test again with our test server? Then approve the PR.

enterprise/resign/resignOwncloudApp Outdated Show resolved Hide resolved
enterprise/resign/resignOwncloudApp Outdated Show resolved Hide resolved
enterprise/resign/resignOwncloudApp Outdated Show resolved Hide resolved
- highlighting output
- fixed wrong provisioning path
- changed version number
- updated readme file
@hosy hosy self-requested a review September 8, 2021 13:53
@hosy
Copy link
Collaborator

hosy commented Sep 8, 2021

@mneuwert I already fixed the requested CR changes and fixed some problems.
@NannaBarz the current version of the script should now work to add associated domains putting a text file domains.txt in the resign folder. Every domain name should be in a new line.

@hosy hosy self-assigned this Sep 8, 2021
@hosy
Copy link
Collaborator

hosy commented Sep 8, 2021

@NannaBarz please add a review to this PR, if you tested the new resigning script.

@hosy hosy requested a review from NannaBarz September 8, 2021 14:27
Copy link
Contributor

@michaelstingl michaelstingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damken Cloud App opened, so the script worked 👍

@michaelstingl michaelstingl merged commit 9da7b37 into master Sep 10, 2021
@delete-merged-branch delete-merged-branch bot deleted the feature/resign-assoc-domains branch September 10, 2021 09:39
hosy added a commit that referenced this pull request Sep 16, 2021
* Added associated domains to resign script (#1028)

* First version of the associated domains addition feature in the resign script

* - lines from domains.txt were not correct read
- highlighting output
- fixed wrong provisioning path
- changed version number
- updated readme file

Co-authored-by: Michael Neuwert <michael.neuwert@gmail.com>
Co-authored-by: Matthias Hühne <github@hosy.de>

* #894 - Fixed Keyboard does not disappear (on jump to PDF Page)

Co-authored-by: Michael Neuwert <michael.neuwert@googlemail.com>
Co-authored-by: Michael Neuwert <michael.neuwert@gmail.com>
Co-authored-by: Matthias Hühne <github@hosy.de>
Co-authored-by: Matthias Hühne <mhuehne@owncloud.com>
hosy added a commit that referenced this pull request Sep 16, 2021
* Added associated domains to resign script (#1028)

* First version of the associated domains addition feature in the resign script

* - lines from domains.txt were not correct read
- highlighting output
- fixed wrong provisioning path
- changed version number
- updated readme file

Co-authored-by: Michael Neuwert <michael.neuwert@gmail.com>
Co-authored-by: Matthias Hühne <github@hosy.de>

* #1033 - In pdf preview, Go to Page don't take user to last page

Co-authored-by: Michael Neuwert <michael.neuwert@googlemail.com>
Co-authored-by: Michael Neuwert <michael.neuwert@gmail.com>
Co-authored-by: Matthias Hühne <github@hosy.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants