Skip to content
This repository has been archived by the owner on Jun 19, 2023. It is now read-only.

Use new filetype icons #456

Closed
jancborchardt opened this issue Aug 28, 2015 · 12 comments
Closed

Use new filetype icons #456

jancborchardt opened this issue Aug 28, 2015 · 12 comments

Comments

@jancborchardt
Copy link
Member

From core master: https://github.com/owncloud/core/tree/master/core/img/filetypes

Preview:
filetype icons new

They are 16*16px but of course scale them up. Please only in multiples of 16px, for example 48px.

This should be done in sync with the release of 8.2 server. cc @rperezb @MTRichards @ggdiez @javiergonzper

@jancborchardt
Copy link
Member Author

Same for Android: owncloud/android#1118

@javiergonzper
Copy link
Contributor

Nice icons! Sure we have to include them into the mobile apps

@javiergonzper
Copy link
Contributor

@jancborchardt looks much better now! 😄

screen shot 2015-09-04 at 14 01 54

@jancborchardt
Copy link
Member Author

WOW, nice! :) A detail: The icons should move a bit more to the right, towards the text. Maybe centered between the left edge and the text.

@javiergonzper
Copy link
Contributor

It is in the center because you have to take into account also the Favorite icons and the Download icons

screen shot 2015-09-04 at 14 20 27

@karlitschek
Copy link
Contributor

It really looks nice. Thanks guys. One think that always bothered me is that the icons on the bottom (Files, Upload, Share link,..) look a bit cramped. It would be cool to have a tiny bit of additional space at the bottom and top of the toolbar.
What do you think?

@joeplus
Copy link

joeplus commented Sep 4, 2015

I agree! Additionally, would it make more sense to have the "favourite" and "download" overlay also all the way on the top right where currently the "share" icon is over the file name? I think it would be cleaner and the filetype icons could move in towards the right.

Should the icon for "Files" on the bottom also be changed to the new icon for "File"? To me they look a little outdated and just not in line with the great new icons for the filetypes.

@jancborchardt
Copy link
Member Author

@karlitschek @joeplus those are different topics, would be good to open separate issues for them. ;)

@javiergonzper I know, but it’s fine if the download and fav icons overlay the filetype icons a bit. It’s more important that the default layout looks fine. So please move the filetype icons a bit to the right.

@karlitschek
Copy link
Contributor

@jancborchardt agreed. I tried to sneak this in here :-)

@karlitschek
Copy link
Contributor

#469

@joeplus
Copy link

joeplus commented Sep 7, 2015

#470

@javiergonzper
Copy link
Contributor

@jancborchardt I will close this issue and we can continue searching a solution on the #470 because this issue was just to update the icons with the new ones not to change the design of the Cell

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants