Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add codecoverage #114

Merged
merged 1 commit into from Nov 16, 2018
Merged

Add codecoverage #114

merged 1 commit into from Nov 16, 2018

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Nov 16, 2018

code coverage is now generated and pushed to codecov.io

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1b8bf06). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #114   +/-   ##
=========================================
  Coverage          ?   83.27%           
=========================================
  Files             ?       11           
  Lines             ?      927           
  Branches          ?        0           
=========================================
  Hits              ?      772           
  Misses            ?      155           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b8bf06...ad459b9. Read the comment docs.

var owncloud = require('../owncloud/index.js')
var oc = new owncloud()

window.oc = oc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has to go away - tests need to be written in es6 and transpiled

Copy link

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm fine with this, unless you need minimal time to rewrite this in ES6...

@DeepDiver1975
Copy link
Member Author

unless you need minimal time to rewrite this in ES6...

I'll do this in a follow up pr - THX

@DeepDiver1975 DeepDiver1975 merged commit 5a8d17b into master Nov 16, 2018
@DeepDiver1975 DeepDiver1975 deleted the coverage branch November 16, 2018 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants