New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce uninstalling #67

Merged
merged 5 commits into from May 11, 2017

Conversation

Projects
None yet
5 participants
@felixheidecke
Contributor

felixheidecke commented May 5, 2017

Also includes:

  • improved error handling
  • consolidated application actions

@felixheidecke felixheidecke requested review from tboerger and DeepDiver1975 May 5, 2017

@felixheidecke

This comment has been minimized.

Show comment
Hide comment
@felixheidecke

felixheidecke May 5, 2017

Contributor

@DeepDiver1975 This requires the API to return status codes outside the 200 range for it to work!

Contributor

felixheidecke commented May 5, 2017

@DeepDiver1975 This requires the API to return status codes outside the 200 range for it to work!

Show outdated Hide outdated src/App.vue
@@ -12,6 +12,10 @@
import Navigation from './components/Navigation.vue';
export default {
mounted: function () {
this.$store.dispatch('FETCH_APPLICATIONS')

This comment has been minimized.

@tboerger

tboerger May 5, 2017

Contributor

Uhm... No? It's not used there so it should not be fetched there.

@tboerger

tboerger May 5, 2017

Contributor

Uhm... No? It's not used there so it should not be fetched there.

This comment has been minimized.

@felixheidecke

felixheidecke May 8, 2017

Contributor

The "problem" here is, that whenever we change views, the applications will be fetched again and again and again and we don't want that.

App.vue will be mounted only once and whether we start in the list, the detail or the update view, so we can minimize API calls.

Re-fetching will occur after application processes such as installing, uninstalling and updating.

@felixheidecke

felixheidecke May 8, 2017

Contributor

The "problem" here is, that whenever we change views, the applications will be fetched again and again and again and we don't want that.

App.vue will be mounted only once and whether we start in the list, the detail or the update view, so we can minimize API calls.

Re-fetching will occur after application processes such as installing, uninstalling and updating.

This comment has been minimized.

@tboerger

tboerger May 9, 2017

Contributor

Than use created, but this approach is totally wrong. Edit: And additionally to that some timestamp to refetch it if it's too old.

@tboerger

tboerger May 9, 2017

Contributor

Than use created, but this approach is totally wrong. Edit: And additionally to that some timestamp to refetch it if it's too old.

This comment has been minimized.

@tboerger

tboerger May 9, 2017

Contributor

Re-fetching will occur after application processes such as installing, uninstalling and updating.

And this shows a poor API design :)

@tboerger

tboerger May 9, 2017

Contributor

Re-fetching will occur after application processes such as installing, uninstalling and updating.

And this shows a poor API design :)

This comment has been minimized.

@felixboehm

felixboehm May 10, 2017

Please merge for now and change Frontend when API is existing.
No reason for a blocker.

@felixboehm

felixboehm May 10, 2017

Please merge for now and change Frontend when API is existing.
No reason for a blocker.

@felixheidecke felixheidecke removed the request for review from DeepDiver1975 May 11, 2017

felixheidecke and others added some commits May 5, 2017

@DeepDiver1975 DeepDiver1975 merged commit c22472a into master May 11, 2017

2 checks passed

Scrutinizer 8 new issues, 1 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@DeepDiver1975 DeepDiver1975 deleted the uninstall branch May 11, 2017

@PVince81 PVince81 added this to the 10.0.1 milestone May 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment