Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go micro v3 #1670

Merged
merged 33 commits into from
Feb 22, 2021
Merged

Update go micro v3 #1670

merged 33 commits into from
Feb 22, 2021

Conversation

butonic
Copy link
Member

@butonic butonic commented Feb 17, 2021

  • etcd registry requires replacing:
    // taken from https://github.com/asim/go-micro/blob/master/plugins/registry/etcd/go.mod#L14-L16
    go.etcd.io/etcd/api/v3 => go.etcd.io/etcd/api/v3 v3.0.0-20210204162551-dae29bb719dd
    go.etcd.io/etcd/pkg/v3 => go.etcd.io/etcd/pkg/v3 v3.0.0-20210204162551-dae29bb719dd
    
  • micro/cli/v2 cannot be replaced with urfave/cli because the micro v3 interfaces use micro/cli/v2 for flags
  • removed ocis-pkg http server option.Hander -> use micro.RegisterHandler(service.Service, handler) instead to resemble the grpc server
  • upstream pr Support for tls on the server http plugin go-micro/go-micro#2126
  • tons of protobuf warnings:
    2021/02/17 16:52:07 WARNING: proto: extension number 1042 is already registered on message google.protobuf.MethodOptions
    A future release will panic on registration conflicts. See:
    https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict
    
    maybe regenerate all protobuf? or use another version of google.golang.org/grpc v1.29.1
  • check if we can use micros prometheus wrapper instead of the one in ocis-pkg, use it for http & grpc

@update-docs
Copy link

update-docs bot commented Feb 17, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review February 18, 2021 10:15
butonic and others added 4 commits February 18, 2021 10:58
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Feb 18, 2021

@C0rby maybe the domain is not set up correctly ?

5804 | 16) Scenario: closing media viewer is possible (attempt 1, retried) # tests/acceptance/features/webUIPreview/imageMediaViewer.feature:65
5805 | ✔ Before # tests/acceptance/setup.js:28
5806 | ✔ Before # tests/acceptance/setup.js:32
5807 | ✔ Before # tests/acceptance/setup.js:36
5808 | ✔ Before # tests/acceptance/setup.js:46
5809 | ✔ Before # tests/acceptance/setup.js:68
5810 | ✔ Before # tests/acceptance/setup.js:75
5811 | ✔ Before # tests/acceptance/stepDefinitions/filesContext.js:16
5812 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:248
5813 | ✔ Before # tests/acceptance/stepDefinitions/generalContext.js:287
5814 | ✔ Given user "user1" has been created with default attributes # tests/acceptance/stepDefinitions/provisioningContext.js:157
5815 | ✔ Given user "user1" has uploaded file "testavatar.jpg" to "testavatar.jpg" # tests/acceptance/stepDefinitions/filesContext.js:98
5816 | ✔ And user "user1" has logged in using the webUI # tests/acceptance/stepDefinitions/loginContext.js:67
5817 | ✖ And the user has viewed the file "testavatar.jpg" in the media viewer using the webUI # tests/acceptance/stepDefinitions/previewContext.js:7
5818 | Timed out while waiting for element <//div[contains(@class,"uk-position-bottom-center")]/div[contains(text(),"testavatar.jpg")]> to be present for 20000 milliseconds. - expected "visible" but got: "not found" (20023ms)
5819 | at Proxy.waitForMediaViewerLoaded (/srv/app/web/tests/acceptance/pageObjects/FilesPageElement/mediaViewerPage.js:17:10)
5820 | at _callee$ (/srv/app/web/tests/acceptance/stepDefinitions/previewContext.js:11:26)
5821 | at runMicrotasks (<anonymous>)
5822 | at processTicksAndRejections (internal/process/task_queues.js:97:5)
5823 | - When the user closes the media resource using the webUI # tests/acceptance/stepDefinitions/previewContext.js:28
5824 | - Then the file "testavatar.jpg" should not be displayed in the media viewer webUI # tests/acceptance/stepDefinitions/previewContext.js:40
5825 | - And the user should be in the root directory on the webUI # tests/acceptance/stepDefinitions/filesContext.js:1246
5826 | ✔ After # tests/acceptance/stepDefinitions/provisioningContext.js:239
5827 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:299
5828 | ✔ After # tests/acceptance/stepDefinitions/generalContext.js:272
5829 | ✔ After # tests/acceptance/setup.js:110
5830 | ✔ After # tests/acceptance/setup.js:106
5831 | ✔ After # tests/acceptance/setup.js:102
5832 | ✔ After # tests/acceptance/setup.js:95
5833 | ✔ After # tests/acceptance/setup.js:86
5834 | ✔ After # tests/acceptance/setup.js:54
5835

Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
Copy link
Member Author

butonic commented Feb 18, 2021

@C0rby locally I can reproduce the thumbnails not working when using the owncloud driver and setting the THUMBNAILS_WEBDAVSOURCE_BASEURL="https://cloud.ocis.test/remote.php/webdav/" which is my url ...
89b06de should fix it

@sonarcloud
Copy link

sonarcloud bot commented Feb 18, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@butonic butonic merged commit aea5058 into master Feb 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the update-go-micro-v3 branch February 22, 2021 09:20
ownclouders pushed a commit that referenced this pull request Feb 22, 2021
Merge: 64dd0ba 89b06de
Author: Jörn Friedrich Dreyer <jfd@butonic.de>
Date:   Mon Feb 22 10:20:34 2021 +0100

    Merge pull request #1670 from owncloud/update-go-micro-v3

    Update go micro v3
@micbar micbar mentioned this pull request Mar 9, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants