Skip to content

Add favorites capability #2599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Add favorites capability #2599

merged 1 commit into from
Oct 11, 2021

Conversation

@kulmann
Copy link
Contributor

@kulmann kulmann commented Oct 8, 2021

Description

This PR adds a capability for files.favorites which is used to announce favorites support to clients. By default it's disabled for now because the implementation of the REPORT request doesn't allow service restarts as of now (there's no re-indexing of favorites, yet).

Motivation and Context

Allow to use the experimental state of favorites.

How Has This Been Tested?

  • manually tested, since this is "only" a new capability.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Oct 8, 2021
wkloucek
wkloucek approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@wkloucek wkloucek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@C0rby C0rby merged commit 43b8849 into master Oct 11, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-favorites-capability branch October 11, 2021 08:36
ownclouders pushed a commit that referenced this pull request Oct 11, 2021
commit 43b8849
2a92a86 
Merge: f63fe92 489d0a5
Author: David Christofas <dchristofas@owncloud.com>
Date:   Mon Oct 11 10:36:00 2021 +0200

    Merge pull request #2599 from owncloud/add-favorites-capability

    Add favorites capability
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wkloucek wkloucek wkloucek approved these changes

@ishank011 ishank011 Awaiting requested review from ishank011

@labkode labkode Awaiting requested review from labkode

+1 more reviewer

@C0rby C0rby C0rby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kulmann kulmann

Labels

Category:Enhancement Add new functionality Early-Adopter:CERN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kulmann @C0rby @wkloucek