Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop json config support #3366

Merged
merged 8 commits into from Mar 28, 2022
Merged

drop json config support #3366

merged 8 commits into from Mar 28, 2022

Conversation

wkloucek
Copy link
Contributor

Description

this PR drops json config support for all oCIS services. From now on only YAML config files are supported.

Related Issue

Motivation and Context

YAML is a superset of JSON and allows one to add comments. This enables us to add comments to example config files and the user to document his/her settings.

We also don't want to generate example config files for both JSON and YAML.

How Has This Been Tested?

  • locally / CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs
Copy link

update-docs bot commented Mar 23, 2022

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wkloucek wkloucek merged commit 8e49026 into master Mar 28, 2022
@delete-merged-branch delete-merged-branch bot deleted the drop-json-config-support branch March 28, 2022 13:28
ownclouders pushed a commit that referenced this pull request Mar 28, 2022
Merge: 83c13e3 cc7144d
Author: Willy Kloucek <34452982+wkloucek@users.noreply.github.com>
Date:   Mon Mar 28 15:28:44 2022 +0200

    Merge pull request #3366 from owncloud/drop-json-config-support

    drop json config support
wkloucek added a commit to owncloud/web that referenced this pull request Mar 28, 2022
fschade pushed a commit to owncloud/web that referenced this pull request Mar 28, 2022
wkloucek added a commit to owncloud/ocis-hello that referenced this pull request Mar 28, 2022
@micbar micbar mentioned this pull request Mar 29, 2022
22 tasks
@intunio-johan
Copy link

The documentation in some cases only give examples of json files, for example I have no clue about how to enable a plugin using yaml configuration. Could somebody with the knowledge possibly update the documentation?

https://owncloud.dev/extensions/ocis_hello/running/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants