New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updater is not copying over ca-bundle.crt? #164

Closed
ghost opened this Issue Aug 14, 2015 · 32 comments

Comments

Projects
None yet
10 participants
@ghost

ghost commented Aug 14, 2015

Hi,

i'm not using the updater so i can't reproduce this but i have now read from three different people that they used the updater to go from 8.0.5 to 8.1.1 (owncloud/core#17448 (comment)) and afterwards the config/ca-bundle.crt was missing.

Anyone could try to reproduce this to avoid issues with failed connections to the appstore and similar problems.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 14, 2015

Member

Ok. That's the source why we have all the bug reports in core. Great.

We shall add an hard requirement in core and next time ensure proper testing. Thanks.

cc @karlitschek

Member

LukasReschke commented Aug 14, 2015

Ok. That's the source why we have all the bug reports in core. Great.

We shall add an hard requirement in core and next time ensure proper testing. Thanks.

cc @karlitschek

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 14, 2015

Member

This breaks a lot. Awesome … 🚀

Member

LukasReschke commented Aug 14, 2015

This breaks a lot. Awesome … 🚀

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 14, 2015

Member

d9b8f19

We really need some logic check that ensures that the current updater is even able to update to the next version…

Member

LukasReschke commented Aug 14, 2015

d9b8f19

We really need some logic check that ensures that the current updater is even able to update to the next version…

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Aug 14, 2015

Member

Hmmm. Actually our documentation says that you can keep the config folder as is. That a bundle needs to be copied is not exactly intuitive or error prove.
@VicDeo Can we fix that?

Member

karlitschek commented Aug 14, 2015

Hmmm. Actually our documentation says that you can keep the config folder as is. That a bundle needs to be copied is not exactly intuitive or error prove.
@VicDeo Can we fix that?

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 14, 2015

Member

It's not only that bundle. - That folder is used for other purposes as well such as mimetype mappings,

That said, there is already a "fix" for this. What the problem is that the updater is just delivering updates for versions it is not capable of which will explode hard.

Member

LukasReschke commented Aug 14, 2015

It's not only that bundle. - That folder is used for other purposes as well such as mimetype mappings,

That said, there is already a "fix" for this. What the problem is that the updater is just delivering updates for versions it is not capable of which will explode hard.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 14, 2015

Member

Also related to owncloud/core#18309 - would make everything way more stable.

Member

LukasReschke commented Aug 14, 2015

Also related to owncloud/core#18309 - would make everything way more stable.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 14, 2015

@LukasReschke Its not sure that the updater isn't copy over the bundle. I'm just guessing after the reports linked above and at forum/irc. This still needs to be verified.

ghost commented Aug 14, 2015

@LukasReschke Its not sure that the updater isn't copy over the bundle. I'm just guessing after the reports linked above and at forum/irc. This still needs to be verified.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Aug 15, 2015

Member

@LukasReschke Its not sure that the updater isn't copy over the bundle. I'm just guessing after the reports linked above and at forum/irc. This still needs to be verified.

It doesn't. At least not when coming from 8.0.5. Which I did on my instance :-)

Member

LukasReschke commented Aug 15, 2015

@LukasReschke Its not sure that the updater isn't copy over the bundle. I'm just guessing after the reports linked above and at forum/irc. This still needs to be verified.

It doesn't. At least not when coming from 8.0.5. Which I did on my instance :-)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Aug 15, 2015

Ah, sure. The files.json of the updater shipped with 8.0.5 doesn't contain the bundle:

https://github.com/owncloud/updater/blob/stable8/lib/files.json

ghost commented Aug 15, 2015

Ah, sure. The files.json of the updater shipped with 8.0.5 doesn't contain the bundle:

https://github.com/owncloud/updater/blob/stable8/lib/files.json

@tech4eleven

This comment has been minimized.

Show comment
Hide comment
@tech4eleven

tech4eleven Sep 18, 2015

I just tried to update via the updater in the admin section. I had 8.0.x and wanted to update to current 8.1.3. Getting a message that says:

Updating ownCloud to version 8.1.3, this may take a while.
Turned on maintenance mode
Exception: Please upload the ca-bundle.crt file into the 'config' directory.
The update was unsuccessful. Please report this issue to the ownCloud community.

What can I do? http://cloud.tech4eleven.com

tech4eleven commented Sep 18, 2015

I just tried to update via the updater in the admin section. I had 8.0.x and wanted to update to current 8.1.3. Getting a message that says:

Updating ownCloud to version 8.1.3, this may take a while.
Turned on maintenance mode
Exception: Please upload the ca-bundle.crt file into the 'config' directory.
The update was unsuccessful. Please report this issue to the ownCloud community.

What can I do? http://cloud.tech4eleven.com

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 18, 2015

This:

Please upload the ca-bundle.crt file into the 'config' directory.

until this issue here has been sorted out.

ghost commented Sep 18, 2015

This:

Please upload the ca-bundle.crt file into the 'config' directory.

until this issue here has been sorted out.

@VicDeo

This comment has been minimized.

Show comment
Hide comment
@VicDeo
Member

VicDeo commented Sep 18, 2015

@tech4eleven

This comment has been minimized.

Show comment
Hide comment
@tech4eleven

tech4eleven Sep 18, 2015

right after i posted this i figured i could try to download the own cloud zip from the website and copy over the crt file. so literally just did that and it worked. thanks all.

tech4eleven commented Sep 18, 2015

right after i posted this i figured i could try to download the own cloud zip from the website and copy over the crt file. so literally just did that and it worked. thanks all.

@ghost ghost referenced this issue Sep 21, 2015

Closed

During upgrade to 8.1.3 #19204

@MALPI

This comment has been minimized.

Show comment
Hide comment
@MALPI

MALPI Sep 22, 2015

Actually after putting the zip file manually there, the upgrade process was stuck. I had to put the new binaries manually into the installation also, run occ upgrade. Still OC didn't leave maintenance mode. After setting the flag manually to false OC was at least able to start again.

Last but not least, the gallery App didn't work anymore, I had to replace it by gallery+. It crashed with a NoRoute...Exception by symfony.

Overall this upgrade was really painfull!

MALPI commented Sep 22, 2015

Actually after putting the zip file manually there, the upgrade process was stuck. I had to put the new binaries manually into the installation also, run occ upgrade. Still OC didn't leave maintenance mode. After setting the flag manually to false OC was at least able to start again.

Last but not least, the gallery App didn't work anymore, I had to replace it by gallery+. It crashed with a NoRoute...Exception by symfony.

Overall this upgrade was really painfull!

@karlitschek

This comment has been minimized.

Show comment
Hide comment
@karlitschek

karlitschek Sep 22, 2015

Member

@LukasReschke where are we with moving the bundle to /core ? Can't find the pr at the moment.

Member

karlitschek commented Sep 22, 2015

@LukasReschke where are we with moving the bundle to /core ? Can't find the pr at the moment.

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Sep 22, 2015

Member

At the "people discussing about mimetype and whatever" state… owncloud/core#18893 🙊

Member

LukasReschke commented Sep 22, 2015

At the "people discussing about mimetype and whatever" state… owncloud/core#18893 🙊

@LukasReschke

This comment has been minimized.

Show comment
Hide comment
@LukasReschke

LukasReschke Sep 23, 2015

Member

Merged. So now we need to ensure that the updater copies the new folder 🙈

cc @VicDeo

Member

LukasReschke commented Sep 23, 2015

Merged. So now we need to ensure that the updater copies the new folder 🙈

cc @VicDeo

@23d-conception

This comment has been minimized.

Show comment
Hide comment
@23d-conception

23d-conception Sep 23, 2015

Hello,
Not sure it's the good solution, but I have solve it simply with add an empty ca-bundle.crt file in config folder ;)

23d-conception commented Sep 23, 2015

Hello,
Not sure it's the good solution, but I have solve it simply with add an empty ca-bundle.crt file in config folder ;)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Sep 23, 2015

Thats definitely the worst solution. Instead follow the instructions some posts above describing where to get a valid ca-bundle.crt.

ghost commented Sep 23, 2015

Thats definitely the worst solution. Instead follow the instructions some posts above describing where to get a valid ca-bundle.crt.

@janusbenissa

This comment has been minimized.

Show comment
Hide comment
@janusbenissa

janusbenissa Oct 19, 2015

Sorry but try to update and get this error, try to find the file but it is not in the master/config ?

janusbenissa commented Oct 19, 2015

Sorry but try to update and get this error, try to find the file but it is not in the master/config ?

@ghost

This comment has been minimized.

Show comment
Hide comment
@janusbenissa

This comment has been minimized.

Show comment
Hide comment
@janusbenissa

janusbenissa Oct 19, 2015

Thanks for the answer
But sorry i'm not a programmer and I was expect a download link so that I can upload it into the config directory (i can't make a crt file with notepad ++ otherwise I make it myself)

"Exception: Please upload the ca-bundle.crt file into the 'config' directory."

janusbenissa commented Oct 19, 2015

Thanks for the answer
But sorry i'm not a programmer and I was expect a download link so that I can upload it into the config directory (i can't make a crt file with notepad ++ otherwise I make it myself)

"Exception: Please upload the ca-bundle.crt file into the 'config' directory."

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 19, 2015

This is a download-link. Open https://raw.githubusercontent.com/owncloud/core/master/resources/config/ca-bundle.crt, save-page as -> save to config dir

ghost commented Oct 19, 2015

This is a download-link. Open https://raw.githubusercontent.com/owncloud/core/master/resources/config/ca-bundle.crt, save-page as -> save to config dir

@janusbenissa

This comment has been minimized.

Show comment
Hide comment
@janusbenissa

janusbenissa Oct 19, 2015

Oke,, I know I was missing something :-)
Thanks, everything works now and I can use version 8.1.3

janusbenissa commented Oct 19, 2015

Oke,, I know I was missing something :-)
Thanks, everything works now and I can use version 8.1.3

@euneuber

This comment has been minimized.

Show comment
Hide comment
@euneuber

euneuber Oct 24, 2015

don't forget to make ca-bundle.crt readable to your web server ;-)

euneuber commented Oct 24, 2015

don't forget to make ca-bundle.crt readable to your web server ;-)

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 24, 2015

Which should be really obvious :)

ghost commented Oct 24, 2015

Which should be really obvious :)

@Kissaki

This comment has been minimized.

Show comment
Hide comment
@Kissaki

Kissaki Oct 25, 2015

Where should the file be coming from?
I checked the github repository master config folder which was linked above, with no such file.
I then downloaded 8.2.0, which does not have such a file either.
While a direct link to a ca-bundle.crt was linked above, its user content. (You can obviously check the user accounts association with owncloud, but this whole mess is less than ideal.)

Kissaki commented Oct 25, 2015

Where should the file be coming from?
I checked the github repository master config folder which was linked above, with no such file.
I then downloaded 8.2.0, which does not have such a file either.
While a direct link to a ca-bundle.crt was linked above, its user content. (You can obviously check the user accounts association with owncloud, but this whole mess is less than ideal.)

@Kissaki

This comment has been minimized.

Show comment
Hide comment
@Kissaki

Kissaki Oct 25, 2015

The file does exist in the 8.1.3 version package.

Kissaki commented Oct 25, 2015

The file does exist in the 8.1.3 version package.

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Oct 25, 2015

@Kissaki For oC 8.2.0 this is not needed anymore. The file is placed within the /resources/config and is already copied over if you do a correct upgrade.

ghost commented Oct 25, 2015

@Kissaki For oC 8.2.0 this is not needed anymore. The file is placed within the /resources/config and is already copied over if you do a correct upgrade.

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 20, 2016

Member

Also happening when updating from 8.0.14 to 8.1.9 (using a test update server),
I can see that the file "ca-bundle.crt" does exist in the tarball, but the updater app from 8.0 doesn't seem to copy it properly.

CC @davitol

Member

PVince81 commented Jul 20, 2016

Also happening when updating from 8.0.14 to 8.1.9 (using a test update server),
I can see that the file "ca-bundle.crt" does exist in the tarball, but the updater app from 8.0 doesn't seem to copy it properly.

CC @davitol

@PVince81 PVince81 added this to the 8.0.15 milestone Jul 20, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Jul 20, 2016

Member

@VicDeo is there anything we can do with the old updater code to make it at least process this file correctly ?

Member

PVince81 commented Jul 20, 2016

@VicDeo is there anything we can do with the old updater code to make it at least process this file correctly ?

This was referenced Aug 8, 2016

@PVince81

This comment has been minimized.

Show comment
Hide comment
@PVince81

PVince81 Aug 16, 2016

Member

it will here #367

Member

PVince81 commented Aug 16, 2016

it will here #367

@PVince81 PVince81 closed this Sep 13, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment