[New updater] Updater tries to do a md5 of a missing file #260

Closed
jvillafanez opened this Issue Mar 2, 2016 · 2 comments

Projects

None yet

4 participants

@jvillafanez

Steps to reproduce

  1. Install ownCloud 9.0.0RC1 (or previous version)
  2. Update to a newer version

Expected behaviour

Upgrade is made fine

Actual behaviour

Updater tries to do a md5 of a missing file. The upgrade finish fine

Server configuration

Operating system: ubuntu 14.04

Web server: apache 2.4.7

Database: mysql

PHP version: 5.5.9

ownCloud version: 9.0.0RC1

Updated from an older ownCloud or fresh install:

Updater trace

ownCloud updater 1.0 - CLI based ownCloud server upgrades
Checking system health.
 - file permissions are ok.
Current version is 9.0.0.16
9.1.0 pre alpha is found online
What would you do next?
  [0] download
  [1] upgrade
  [2] abort
 > 1
PHP Warning:  md5_file(/opt/owncloud/data/updater-data/download/9.1.0.tar.bz2): failed to open stream: No such file or directory in /opt/owncloud/updater/src/Utils/FilesystemHelper.php on line 68
Downloaded 100% (28426685 of 28426685)
Created checkpoint 9.0.0.16-56d6b8d839a64
 simulated (optionally, can be done online in advance)
real [danger, might take long]
Extracting source into ./_oc_upgrade/9.1.0
ownCloud or one of the apps require upgrade - only a limited number of commands are available
You may use your browser or the occ upgrade command to do the upgrade
Set log level to debug
Turned on maintenance mode
Checking whether the database schema can be updated (this can take a long time depending on the database size)
Checked database schema update
Checking updates of apps
Checked database schema update for apps
Updating database schema
Updated database
Starting code integrity check...
Finished code integrity check
Update successful
Turned off maintenance mode
Reset log level

Upgrading the application activity
Upgrading the application comments
Upgrading the application dav
Upgrading the application federatedfilesharing
Upgrading the application files
Upgrading the application files_pdfviewer
Upgrading the application files_sharing
Upgrading the application files_texteditor
Upgrading the application files_trashbin
Upgrading the application files_versions
Upgrading the application files_videoplayer
Upgrading the application firstrunwizard
Upgrading the application gallery
Upgrading the application notifications
Upgrading the application provisioning_api
Upgrading the application systemtags
Upgrading the application templateeditor
Upgrading the application updatenotification
Upgrading the application encryption
Upgrading the application external
Upgrading the application federation
Upgrading the application files_external
Upgrading the application user_external
Upgrading the application user_ldap
Done
Done
@jvillafanez jvillafanez added the bug label Mar 2, 2016
@jvillafanez jvillafanez added this to the 9.0.1-next-maintenance milestone Mar 2, 2016
@PVince81 PVince81 added the sev3-medium label Mar 9, 2016
@VicDeo
Member
VicDeo commented Mar 9, 2016

@jvillafanez please post output for ./occ config:app:get core OC_Channel

@VicDeo
Member
VicDeo commented Mar 9, 2016

@jvillafanez ah, wait. Do you use patched Feed class while testing?
UPD Nevermind. It's here $checksumMatch should be assigned only if $fileExists is true
https://github.com/owncloud/updater/blob/stable9/src/Controller/DownloadController.php#L107

@VicDeo VicDeo closed this in #286 Mar 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment